Form submit prevention changes

[agentcooper]

Right now the condition is

if (!attr.action) {
  // prevent submit
}

(https://github.com/angular/angular.js/blob/master/src/ng/directive/form.js#L310)

This breaks lots of existing forms with action="", which is useful when sending POST to the same page. In current situation, to fix this, we need to change our templates to something like action="<? $_SERVER['PHP_SELF'] ?>".

I suggest changing the condition to

if (!attr.action && attr.action !== '') {
  // prevent submit
}

Does this make any sense?

[IgorMinar]

yes. I think this is valid issue. falsy-ness check is not sufficient here as action="" still gets "prevented".

[drkwolf]

why is it not yet merged ?

[thebigredgeek]

@drkwolf , just build the PR branch locally in the mean time with changes merged in from master

[robjames]

+1

[totof3110]

Just got bitten by this bug. If the action attribute is a substitution based on a variable read asynchronously (Ajax) this seems to also happen:

<form action="{{someObject.actionUrl}}" method="post">

=> when someObject is the result of an Ajax call, Angular seems to initialize the action tag as an empty string and then prevent default form submit, even after the action is populated.