Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

Several issues at the directive documentation #1799

Closed
lgalfaso opened this issue Jan 13, 2013 · 1 comment
Closed

Several issues at the directive documentation #1799

lgalfaso opened this issue Jan 13, 2013 · 1 comment

Comments

@lgalfaso
Copy link
Contributor

There are several issues at the documentation at http://docs.angularjs.org/guide/directive at the section "Understanding Transclusion and Scopes"

  • [minor] The snippet that uses a /dialog/ is missing a closing div
  • At the scope definition for /title/ the documentation states that it should be " title: '=', " when in fact it should be " title: '@', "
  • At the snippet definition, there is an attribute "visible" that ones expects it to be binded to the parent scope value "show", but at the template and the scope, the value is "show" (this is, the parent "show"). There are several ways to fix this, (a) make the definition at the component scope of "show" from "=" to "=visible", (b) change the name of the attribute from "visible" to "show" or (c) to change the template and scope to use "visible" and not "show" [I would go with the last one to avoid any confusion to however is reading]
  • [minor] on the final directive definition, it is missing the properties "restrict: 'E'" and "replace: true"
@petebacondarwin
Copy link
Contributor

I updated the commit message and merged. Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants