Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

Developer guide is missing navigation controls on iOS #16448

Closed
2 tasks
jessebarnum opened this issue Feb 11, 2018 · 1 comment · Fixed by angular-indonesia/angular.js#115 or javascript-indonesias/angular.js#60

Comments

@jessebarnum
Copy link

I'm submitting a ...

  • [x ] bug report
  • feature request
  • other

Current behavior:

Development guide is not usable on an iPad, because the navigation sidebar on the left is not accessible.

Expected / new behavior:

Position navigation sidebar at top, bottom, or both when using an iPad

Minimal reproduction of the problem with instructions:

View https://docs.angularjs.org/guide on an iPad. Try to navigate to section on 'directives'

AngularJS version: 1.x.y

Browser: [all | Chrome XX | Firefox XX | Edge XX | IE XX | Safari XX | Mobile Chrome XX | Android X.X Web Browser | iOS XX Safari | iOS XX UIWebView | iOS XX WKWebView ]

iOS 11.2.1

Anything else:

I couldn't find a good way to submit feedback specific for documentation. There is a button titled 'Improve this doc,' but that doesn't seem to be a way to provide feedback - it wants you to fork the repository.

gkalpak added a commit to gkalpak/angular.js that referenced this issue Feb 11, 2018
Previously, our custom styles used `@media` breakpoints for
small/extra small devices that were off-by-one from
[Bootstrap breakpoints](https://getbootstrap.com/docs/3.3/css/#responsive-utilities-classes)
(767px vs 768px). This caused the site to not be displayed correctly on
these exact sizes, which affected for example all iPad devices (whose
screens are exactly 768px wide).

This commit fixes it by making our breakpoints match those of Bootstrap.

Fixes angular#16448
@gkalpak gkalpak added this to the Backlog milestone Feb 11, 2018
@gkalpak
Copy link
Member

gkalpak commented Feb 11, 2018

Good spot 😃
It turns out some @media breakpoints were off-by-one causing the site to not be displayed properly as exactly 767px or 768px. (And it turns out iPad is 768px wide 😁)
Should be fixed by #16449.

gkalpak added a commit that referenced this issue Feb 11, 2018
Previously, our custom styles used `@media` breakpoints for
small/extra small devices that were off-by-one from
[Bootstrap breakpoints](https://getbootstrap.com/docs/3.3/css/#responsive-utilities-classes)
(767px vs 768px). This caused the site to not be displayed correctly on
these exact sizes, which affected for example all iPad devices (whose
screens are exactly 768px wide).

This commit fixes it by making our breakpoints match those of Bootstrap.

Fixes #16448

Closes #16449
Narretz pushed a commit to Narretz/angular.js that referenced this issue Feb 12, 2018
Previously, our custom styles used `@media` breakpoints for
small/extra small devices that were off-by-one from
[Bootstrap breakpoints](https://getbootstrap.com/docs/3.3/css/#responsive-utilities-classes)
(767px vs 768px). This caused the site to not be displayed correctly on
these exact sizes, which affected for example all iPad devices (whose
screens are exactly 768px wide).

This commit fixes it by making our breakpoints match those of Bootstrap.

Fixes angular#16448

Closes angular#16449
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.