Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

[BUG] Input[date|time|datetime-local] min & max attributes ignore ngModelOptions timezone #16342

Closed
1 of 3 tasks
Swiftwork opened this issue Nov 23, 2017 · 2 comments
Closed
1 of 3 tasks

[BUG] Input[date|time|datetime-local] min & max attributes ignore ngModelOptions timezone #16342

Swiftwork opened this issue Nov 23, 2017 · 2 comments
Labels
component: forms frequency: low PRs plz! severity: broken expected use type: bug
Milestone
1.6.x

Comments

@Swiftwork
Copy link

I'm submitting a ...

  • bug report
  • feature request
  • other

Current behavior:

Using ngModelOptions developers can set timezone for input[date|time|datetime-local] for parsers and formatters. However this does not affect min and max validation.
https://github.com/angular/angular.js/blob/master/src/ng/directive/input.js#L1475
https://github.com/angular/angular.js/blob/master/src/ng/directive/input.js#L1486
Parsers and formatters take timezone into account.
https://github.com/angular/angular.js/blob/master/src/ng/directive/input.js#L1445

Expected / new behavior:

Take timezone into account when validating minimum and maximum date spans.

Minimal reproduction of the problem with instructions:

Select 2013-12-31 if you aren't on UTC it should be invalid.
https://plnkr.co/edit/i88I219Wke77tdUSA3XF?p=preview

AngularJS version: 1.6.6

Browser: [all]
@Narretz Narretz added this to the 1.6.x milestone Nov 23, 2017
@Narretz
Copy link
Contributor

Narretz commented Nov 23, 2017

This has been reported before: #11221

Let's keep this issue because it's more succinct.

@Narretz Narretz mentioned this issue Nov 23, 2017
Closed
@Narretz
Copy link
Contributor

Narretz commented Nov 23, 2017

I've updated your demo to make it a bit easier to see - https://plnkr.co/edit/zHwbOVw5uI1f8xl9a7RY?p=preview
If you have timezone: UTC and a UTC date, then max should not be true, but in the demo it is.

@m-amr m-amr mentioned this issue Jan 5, 2018
Merged
3 tasks
m-amr added a commit to m-amr/angular.js that referenced this issue Jan 5, 2018
@m-amr
fix(input): take timezone into account when validating minimum and ma…
5fb8d31 
…ximum date spans.

Closes angular#16342
Closes angular#16390
m-amr added a commit to m-amr/angular.js that referenced this issue Jan 5, 2018
@m-amr
fix(input): take timezone into account when validating minimum and ma…
ccdb700 
…ximum date spans.

Closes angular#16342
Closes angular#16390
m-amr added a commit to m-amr/angular.js that referenced this issue Jan 5, 2018
@m-amr
fix(input): take timezone into account when validating minimum and ma…
a0861ea 
…ximum date spans

Closes angular#16342
Closes angular#16390
m-amr added a commit to m-amr/angular.js that referenced this issue Jan 5, 2018
@m-amr
fix(input): take timezone into account when validating minimum and ma…
8b9af1f 
…ximum date spans

Closes angular#16342
Closes angular#16390
m-amr added a commit to m-amr/angular.js that referenced this issue Jan 5, 2018
@m-amr
fix(input): take timezone into account when validating minimum and ma…
66a8a8e 
…ximum date spans

Closes angular#16342
Closes angular#16390
m-amr added a commit to m-amr/angular.js that referenced this issue Jan 5, 2018
@m-amr
fix(input): take timezone into account when validating minimum and ma…
e5401c9 
…ximum date spans

Closes angular#16342
Closes angular#16390
m-amr added a commit to m-amr/angular.js that referenced this issue Jan 5, 2018
@m-amr
fix(input): take timezone into account when validating minimum and ma…
58fd32a 
…ximum date spans

Closes angular#16342
Closes angular#16390
m-amr added a commit to m-amr/angular.js that referenced this issue Jan 5, 2018
@m-amr
fix(input): take timezone into account when validating minimum and ma…
91418cc 
…ximum date spans

Closes angular#16342
Closes angular#16390
m-amr added a commit to m-amr/angular.js that referenced this issue Jan 5, 2018
@m-amr
fix(input): take timezone into account when validating minimum and ma…
e1f150c 
…ximum date spans

Closes angular#16342
Closes angular#16390
m-amr added a commit to m-amr/angular.js that referenced this issue Jan 5, 2018
@m-amr
fix(input): take timezone into account when validating minimum and ma…
76355f1 
…ximum date spans

Closes angular#16342
Closes angular#16390
m-amr added a commit to m-amr/angular.js that referenced this issue Jan 5, 2018
@m-amr
fix(input): take timezone into account when validating minimum and ma…
f4decfb 
…ximum date spans

Closes angular#16342
Closes angular#16390
m-amr added a commit to m-amr/angular.js that referenced this issue Jan 6, 2018
@m-amr
fix(input): take timezone into account when validating minimum and ma…
38cda5f 
…ximum date spans

Closes angular#16342
Closes angular#16390
m-amr added a commit to m-amr/angular.js that referenced this issue Jan 6, 2018
@m-amr
fix(input): take timezone into account when validating minimum and ma…
483c123 
…ximum date spans

Closes angular#16342
Closes angular#16390
m-amr added a commit to m-amr/angular.js that referenced this issue Jan 6, 2018
@m-amr
fix(input): take timezone into account when validating minimum and ma…
cf071f8 
…ximum date spans

Closes angular#16342
Closes angular#16390
m-amr added a commit to m-amr/angular.js that referenced this issue Jan 6, 2018
@m-amr
fix(input): take timezone into account when validating minimum and ma…
8d9f9cb 
…ximum date spans

Closes angular#16342
Closes angular#16390
m-amr added a commit to m-amr/angular.js that referenced this issue Jan 6, 2018
@m-amr
fix(input): take timezone into account when validating minimum and ma…
7f6ca41 
…ximum date spans

Closes angular#16342
Closes angular#16390
m-amr added a commit to m-amr/angular.js that referenced this issue Jan 7, 2018
@m-amr
fix(input): take timezone into account when validating minimum and ma…
d0c210a 
…ximum date spans

Closes angular#16342
Closes angular#16390
m-amr added a commit to m-amr/angular.js that referenced this issue Jan 7, 2018
@m-amr
fix(input): take timezone into account when validating minimum and ma…
32d76dd 
…ximum date spans

Closes angular#16342
Closes angular#16390
m-amr added a commit to m-amr/angular.js that referenced this issue Feb 3, 2018
@m-amr
fix(input): take timezone into account when validating minimum and ma…
ee5a110 
…ximum date spans

Closes angular#16342
Closes angular#16390
m-amr added a commit to m-amr/angular.js that referenced this issue Mar 10, 2018
@m-amr
fix(input): take timezone into account when validating minimum and ma…
06709f9 
…ximum date spans

Closes angular#16342
Closes angular#16390
m-amr added a commit to m-amr/angular.js that referenced this issue Apr 3, 2018
@m-amr
fix(input): take timezone into account when validating minimum and ma…
08604c0 
…ximum date spans

Closes angular#16342
Closes angular#16390
@Narretz Narretz closed this as completed in b7bb797 Apr 6, 2018
Narretz pushed a commit that referenced this issue Apr 6, 2018
@m-amr @Narretz
fix(input): take timezone into account when validating minimum and ma…
2f0ac69 
…ximum in date types

Closes #16342
Closes #16390
This was referenced Apr 18, 2018
Closed
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
component: forms frequency: low PRs plz! severity: broken expected use type: bug
Projects
None yet
Milestone
1.6.x
Development

No branches or pull requests
2 participants
@Swiftwork @Narretz