$cancelRequest() on completed resource request throws error

[jazdw]

I'm submitting a ...

• bug report
• feature request
• other (Please do not submit support requests here (see above))

Current behavior:

Canceling a completed Angular Resource request using .$cancelRequest() results in

angular.js:123 TypeError: Cannot read property 'resolve' of null
    at Array.cancelRequest (https://localhost:8443/modules/mangoUI/web/vendor/angular-resource/angular-resource.js:831:30)

Expected / new behavior:

The function call should do nothing, as per docs

Calling $cancelRequest() for a non-cancellable or an already completed/cancelled request will have no effect.

Minimal reproduction of the problem with instructions:

Angular version: 1.6.4

Browser: [all]

Anything else:

Looks like this bug was introduced in 71cf28c

[gkalpak]

I could not reproduce it. Can you post a reproduction (preferrably a live demo using CodePen, Plnkr etc)?

[jazdw]

OK, so the issue only occurs if you store a reference to the cancel function. It seems the behaviour has been changed so that the cancel function is replaced by angular.noop

https://codepen.io/jazdw/pen/eWwNdJ

[gkalpak]

Yeah, you should not store a reference. You should use it from the resource instance, because we update the $cancelRequest property on/after every request.

That said, feel free to submit a PR that adds a check inside $cancelRequest to account for properties being null (which means the request has been completed/aborted already).