Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

Add missing / fix incorrect error docs #15852

Closed
4 tasks
Narretz opened this issue Mar 22, 2017 · 8 comments
Closed
4 tasks

Add missing / fix incorrect error docs #15852

Narretz opened this issue Mar 22, 2017 · 8 comments

Comments

@Narretz
Copy link
Contributor

Narretz commented Mar 22, 2017

@Narretz Narretz added this to the Backlog milestone Mar 22, 2017
@JoshuaJWilborn
Copy link
Contributor

Hello again @Narretz Are these 2 more error files similar to the one I just made or a regular doc page?

@Narretz
Copy link
Contributor Author

Narretz commented Mar 24, 2017

Hi @JoshuaJWilborn, for these error you'll need to look into the code and go from there to write a description. I think $route:norout is pretty simple to document, $parse:lval maybe a bit more involved.

@Narretz Narretz modified the milestones: Backlog, 1.7.0 Feb 5, 2018
@petebacondarwin
Copy link
Contributor

Why the breaking change @Narretz ? This is a docs only change, right?

@Narretz
Copy link
Contributor Author

Narretz commented Feb 19, 2018

@petebacondarwin the BC is only for #15844 (comment), because changing the error identifier is technically a BC for apps that check for a specific error code. Very small, but still. Documentation is the description, or the error document - this applies to the other errors listed

@petebacondarwin
Copy link
Contributor

petebacondarwin commented Feb 19, 2018

Regarding this.throwError('IMPOSSIBLE') - the error is actually throw $parseMinErr('esc', 'IMPOSSIBLE');. We should leave that in place. It is there to catch a programming error slipping into the code in the future.

@petebacondarwin petebacondarwin self-assigned this Feb 19, 2018
@petebacondarwin
Copy link
Contributor

petebacondarwin commented Feb 19, 2018

Regarding the tpload error, the change was introduced by @jbedard here: #13701 (comment)

I think to keep things simple we should just remove the $templateMinErr variable and reuse the $compileMinErr variable.

Actually I think we should fix the '$compile' parameter and put it in 1.7.0.

(And it is not worth trying to change the minerr extraction tool :-) )

@Narretz
Copy link
Contributor Author

Narretz commented Feb 20, 2018

@petebacondarwin do you mean the tpload error should have its own namespace, i.e. $templateRequest?

@petebacondarwin
Copy link
Contributor

petebacondarwin commented Feb 20, 2018

1 2 and 3 are fixed on master (56b6ba8, and f1c164c)
4 is partially fixed on master (56b6ba8) and will be completely fixed via #16461

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants