This repository was archived by the owner on Apr 12, 2024. It is now read-only.
Remove ngClick override from ngTouch #15755
Assignees
Milestone
Comments
Narretz
added a commit
to Narretz/angular.js
that referenced
this issue
Feb 28, 2017
…ideEnabled() Closes angular#15755 BREAKING CHANGE: The `ngClick` directive from the ngTouch module has been removed, and with the also the corresponding $touchProvider.ngClickOverrideEnabled() method. If you have included ngTouch in your application with a version of 1.5.0 or higher, and have not changed the value of $touchProvider.ngClickOverrideEnabled()`, then there are no migration steps. The `ngClick` override directive had been deprecated and by default disabled since v1.5.0, because of buggy behavior in edge cases, and a general trend to avoid special touch based overrides of click events. If you still need a touch override, consider using [Fastclick](https://github.com/ftlabs/fastclick). Note that the `$touch` service still offers the `ngClickOverrideEnabled()` function for libraries that want to detect if an app uses the click override. Starting with 1.7.0, it will always return `false`.
Narretz
added a commit
to Narretz/angular.js
that referenced
this issue
Mar 8, 2017
Closes angular#15761 Closes angular#15755 BREAKING CHANGE: The `ngClick` directive from the ngTouch module has been removed, and with the also the corresponding $touchProvider and $touch service. If you have included ngTouch in your application with version 1.5.0 or higher, and have not changed the value of $touchProvider.ngClickOverrideEnabled()`, or injected and used the $touch service, then there are no migration steps for your code. Otherwise you must remove references to the provider and service. The `ngClick` override directive had been deprecated and by default disabled since v1.5.0, because of buggy behavior in edge cases, and a general trend to avoid special touch based overrides of click events. In modern browsers, it should not be necessary to use a touch override library: - Chrome and Firefox for Android remove the 300ms delay when the well-known `<meta name="viewport" content="width=device-width">` is set. - Internet Explorer, Edge, and Chrome remove the delay when the `touch-action` css property is set to `none` or `manipulation`. - Since iOS 8, Safari removes the delay on so-called "slow taps". You can find out more in this Telerik article: http://developer.telerik.com/featured/300-ms-click-delay-ios-8/
Narretz
added a commit
to Narretz/angular.js
that referenced
this issue
Mar 11, 2017
…ideEnabled() Closes angular#15755 BREAKING CHANGE: The `ngClick` directive from the ngTouch module has been removed, and with the also the corresponding $touchProvider.ngClickOverrideEnabled() method. If you have included ngTouch in your application with a version of 1.5.0 or higher, and have not changed the value of $touchProvider.ngClickOverrideEnabled()`, then there are no migration steps. The `ngClick` override directive had been deprecated and by default disabled since v1.5.0, because of buggy behavior in edge cases, and a general trend to avoid special touch based overrides of click events. If you still need a touch override, consider using [Fastclick](https://github.com/ftlabs/fastclick). Note that the `$touch` service still offers the `ngClickOverrideEnabled()` function for libraries that want to detect if an app uses the click override. Starting with 1.7.0, it will always return `false`.
Narretz
added a commit
to Narretz/angular.js
that referenced
this issue
Mar 11, 2017
Closes angular#15761 Closes angular#15755 BREAKING CHANGE: The `ngClick` directive from the ngTouch module has been removed, and with the also the corresponding $touchProvider and $touch service. If you have included ngTouch in your application with version 1.5.0 or higher, and have not changed the value of $touchProvider.ngClickOverrideEnabled()`, or injected and used the $touch service, then there are no migration steps for your code. Otherwise you must remove references to the provider and service. The `ngClick` override directive had been deprecated and by default disabled since v1.5.0, because of buggy behavior in edge cases, and a general trend to avoid special touch based overrides of click events. In modern browsers, it should not be necessary to use a touch override library: - Chrome and Firefox for Android remove the 300ms delay when the well-known `<meta name="viewport" content="width=device-width">` is set. - Internet Explorer, Edge, and Chrome remove the delay when the `touch-action` css property is set to `none` or `manipulation`. - Since iOS 8, Safari removes the delay on so-called "slow taps". You can find out more in this Telerik article: http://developer.telerik.com/featured/300-ms-click-delay-ios-8/
Narretz
added a commit
to Narretz/angular.js
that referenced
this issue
Mar 12, 2017
Closes angular#15761 Closes angular#15755 BREAKING CHANGE: The `ngClick` directive from the ngTouch module has been removed, and with it the corresponding `$touchProvider` and `$touch` service. If you have included ngTouch v1.5.0 or higher in your application, and have not changed the value of `$touchProvider.ngClickOverrideEnabled()`, or injected and used the `$touch` service, then there are no migration steps for your code. Otherwise you must remove references to the provider and service. The `ngClick` override directive had been deprecated and by default disabled since v1.5.0, because of buggy behavior in edge cases, and a general trend to avoid special touch based overrides of click events. In modern browsers, it should not be necessary to use a touch override library: - Chrome, Firefox, Edge, and Safari remove the 300ms delay when `<meta name="viewport" content="width=device-width">` is set. - Internet Explorer 10+, Edge, Safari, and Chrome remove the delay on elements that have the `touch-action` css property is set to `manipulation`. You can find out more in these articles: https://developers.google.com/web/updates/2013/12/300ms-tap-delay-gone-away https://developer.apple.com/library/content/releasenotes/General/WhatsNewInSafari/Articles/Safari_9_1.html#//apple_ref/doc/uid/TP40014305-CH10-SW8 https://blogs.msdn.microsoft.com/ie/2015/02/24/pointer-events-w3c-recommendation-interoperable-touch-and-removing-the-dreaded-300ms-tap-delay/
Narretz
added a commit
that referenced
this issue
Mar 14, 2017
Closes #15761 Closes #15755 BREAKING CHANGE: The `ngClick` directive from the ngTouch module has been removed, and with it the corresponding `$touchProvider` and `$touch` service. If you have included ngTouch v1.5.0 or higher in your application, and have not changed the value of `$touchProvider.ngClickOverrideEnabled()`, or injected and used the `$touch` service, then there are no migration steps for your code. Otherwise you must remove references to the provider and service. The `ngClick` override directive had been deprecated and by default disabled since v1.5.0, because of buggy behavior in edge cases, and a general trend to avoid special touch based overrides of click events. In modern browsers, it should not be necessary to use a touch override library: - Chrome, Firefox, Edge, and Safari remove the 300ms delay when `<meta name="viewport" content="width=device-width">` is set. - Internet Explorer 10+, Edge, Safari, and Chrome remove the delay on elements that have the `touch-action` css property is set to `manipulation`. You can find out more in these articles: https://developers.google.com/web/updates/2013/12/300ms-tap-delay-gone-away https://developer.apple.com/library/content/releasenotes/General/WhatsNewInSafari/Articles/Safari_9_1.html#//apple_ref/doc/uid/TP40014305-CH10-SW8 https://blogs.msdn.microsoft.com/ie/2015/02/24/pointer-events-w3c-recommendation-interoperable-touch-and-removing-the-dreaded-300ms-tap-delay/
ellimist
pushed a commit
to ellimist/angular.js
that referenced
this issue
Mar 15, 2017
Closes angular#15761 Closes angular#15755 BREAKING CHANGE: The `ngClick` directive from the ngTouch module has been removed, and with it the corresponding `$touchProvider` and `$touch` service. If you have included ngTouch v1.5.0 or higher in your application, and have not changed the value of `$touchProvider.ngClickOverrideEnabled()`, or injected and used the `$touch` service, then there are no migration steps for your code. Otherwise you must remove references to the provider and service. The `ngClick` override directive had been deprecated and by default disabled since v1.5.0, because of buggy behavior in edge cases, and a general trend to avoid special touch based overrides of click events. In modern browsers, it should not be necessary to use a touch override library: - Chrome, Firefox, Edge, and Safari remove the 300ms delay when `<meta name="viewport" content="width=device-width">` is set. - Internet Explorer 10+, Edge, Safari, and Chrome remove the delay on elements that have the `touch-action` css property is set to `manipulation`. You can find out more in these articles: https://developers.google.com/web/updates/2013/12/300ms-tap-delay-gone-away https://developer.apple.com/library/content/releasenotes/General/WhatsNewInSafari/Articles/Safari_9_1.html#//apple_ref/doc/uid/TP40014305-CH10-SW8 https://blogs.msdn.microsoft.com/ie/2015/02/24/pointer-events-w3c-recommendation-interoperable-touch-and-removing-the-dreaded-300ms-tap-delay/
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
No description provided.
The text was updated successfully, but these errors were encountered: