Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

The breaking change as by #14202 should be reverted as the reference specification was already officially deprecated #15715

Closed
evilaliv3 opened this issue Feb 16, 2017 · 2 comments

Comments

@evilaliv3
Copy link

evilaliv3 commented Feb 16, 2017

I think that the breaking change introduced in pull request #14202 should be reverted as it makes not any particular sense.

The specification by Google has been officially deprecated since October 2015.

"This recommendation is officially deprecated as of October 2015."
Reference: https://developers.google.com/webmasters/ajax-crawling/docs/getting-started

The deprecation in addition happened long time before the patch was written and committed.

evilaliv3 added a commit to globaleaks/globaleaks-whistleblowing-software that referenced this issue Feb 16, 2017
@Narretz
Copy link
Contributor

Narretz commented Feb 16, 2017

It's a pretty bad idea to revert something that has just been implemented.
I personally think a bigger reason für using a default hashPrefix is that without it, you are messing up your hash anchors, and this was confusing many people.
Also, deprecated doesn't mean obsolete.
Further, reacting to this change is a 3 line code change (as see in your repo).

@Narretz Narretz added this to the Purgatory milestone Feb 16, 2017
@Narretz Narretz changed the title The breaking change as by #14202 should be revered as the reference specification was already officially deprecated The breaking change as by #14202 should be reverted as the reference specification was already officially deprecated Feb 16, 2017
@Narretz
Copy link
Contributor

Narretz commented Feb 22, 2017

I'm going to close this issue because we haven't got any feedback. Feel free to reopen this issue if you can provide new feedback.

@Narretz Narretz closed this as completed Feb 22, 2017
dxmaxwell added a commit to frib-high-level-controls/swdb that referenced this issue Jun 22, 2020
The biggest being a breaking changed in AngularJS:
  angular/angular.js#15715
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants