This repository was archived by the owner on Apr 12, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 27.4k
Two svg compile tests fail in Chrome 54 #15333
Milestone
Comments
👍 I think they started failing on Chrome v53 btw. |
The reason why they fail is that |
gkalpak
added a commit
to gkalpak/angular.js
that referenced
this issue
Nov 30, 2016
…or `<foreignObject>` Chrome 53-54+ on Windows (only) reports a 25% larger size for `<foreignObject>` elements and their descendants (although the size is actually correct on the page). For example, `<foreignObject style="width: 100px; height: 100px;">...</foreignObject>`, will be reported by `getBoundingClientRect()` as being `125px` x `125px`, although it will be `100px` x `100px` as expected. Fixes angular#15333
Closed
3 tasks
Actually, it doesn't seem to be Windows-specific. I can make it fail on Ubuntu too. |
gkalpak
added a commit
to gkalpak/angular.js
that referenced
this issue
Dec 1, 2016
…eignObject>` Since Chrome 53-57+, the reported size of `<foreignObject>` elements and their descendants is affected by global display settings (e.g. font size) and browser settings (e.g. default zoom level). This could cause tests incorrectly failing due to such settings. In order to avoid false negatives, we now compare against the size of the equivalent, hand-written SVG instead of fixed widths/heights. Fixes angular#15333
3 tasks
Narretz
pushed a commit
to Narretz/angular.js
that referenced
this issue
Dec 1, 2016
…eignObject>` Since Chrome 53-57+, the reported size of `<foreignObject>` elements and their descendants is affected by global display settings (e.g. font size) and browser settings (e.g. default zoom level). This could cause tests incorrectly failing due to such settings. In order to avoid false negatives, we now compare against the size of the equivalent, hand-written SVG instead of fixed widths/heights. Fixes angular#15333 Closes angular#15458
gkalpak
added a commit
that referenced
this issue
Dec 1, 2016
…eignObject>` Since Chrome 53-57+, the reported size of `<foreignObject>` elements and their descendants is affected by global display settings (e.g. font size) and browser settings (e.g. default zoom level). This could cause tests incorrectly failing due to such settings. In order to avoid false negatives, we now compare against the size of the equivalent, hand-written SVG instead of fixed widths/heights. Fixes #15333 Closes #15458
ellimist
pushed a commit
to ellimist/angular.js
that referenced
this issue
Mar 15, 2017
…eignObject>` Since Chrome 53-57+, the reported size of `<foreignObject>` elements and their descendants is affected by global display settings (e.g. font size) and browser settings (e.g. default zoom level). This could cause tests incorrectly failing due to such settings. In order to avoid false negatives, we now compare against the size of the equivalent, hand-written SVG instead of fixed widths/heights. Fixes angular#15333 Closes angular#15458
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
These two tests fail in Chrome 54 and Win 10.
angular.js/test/ng/compileSpec.js
Lines 442 to 467 in 5cce6e2
The text was updated successfully, but these errors were encountered: