Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

The guide is missing necessary shims #14655

Closed
mgol opened this issue May 23, 2016 · 2 comments
Closed

The guide is missing necessary shims #14655

mgol opened this issue May 23, 2016 · 2 comments
Assignees
Milestone

Comments

@mgol
Copy link
Member

mgol commented May 23, 2016

Note: for support questions, please use one of these channels: https://github.com/angular/angular.js/blob/master/CONTRIBUTING.md#question. This repository's issues are reserved for feature requests and bug reports.

Do you want to request a feature or report a bug?
Bug

What is the current behavior?
The guide at https://docs.angularjs.org/guide/component-router mentions only the need to load Angular & the router. As we see in https://docs.angularjs.org/api/ngComponentRouter, though, IE needs some shims to make it work. I'd expect the vast majority of Angular 1.x users of the new router to need at least IE 11 support so the guide should provide all necessary steps.

If the current behavior is a bug, please provide the steps to reproduce and if possible a minimal demo of the problem via https://plnkr.co or similar (template: http://plnkr.co/edit/tpl:yBpEi4).
The router will just break in IE.

What is the expected behavior?
The shims should be included in the guide.

What is the motivation / use case for changing the behavior?
To make it work in IE

Which versions of Angular, and which browser / OS are affected by this issue? Did this work in previous versions of Angular? Please also test with the latest stable and snapshot (https://code.angularjs.org/snapshot/) versions.
@angular/router 0.2.0

Other information (e.g. stacktraces, related issues, suggestions how to fix)

@mgol
Copy link
Member Author

mgol commented May 23, 2016

Ported from angular/router#410.

@mgol
Copy link
Member Author

mgol commented May 23, 2016

Also: the shims section at https://docs.angularjs.org/api/ngComponentRouter mentions that they're only needed for IE. However, in reality all non-ES6 browsers need them; this will include also Android <5.0 & iOS <8 users as well as Windows Mobile<10 ones.

Comment ported from angular/router#411.

@petebacondarwin petebacondarwin added this to the 1.5.6 milestone May 24, 2016
@Narretz Narretz modified the milestones: 1.5.6, 1.5.7 May 27, 2016
@Narretz Narretz self-assigned this Jun 6, 2016
Narretz added a commit to Narretz/angular.js that referenced this issue Jun 6, 2016
Narretz added a commit to Narretz/angular.js that referenced this issue Jun 6, 2016
Narretz added a commit to Narretz/angular.js that referenced this issue Jun 6, 2016
petebacondarwin pushed a commit that referenced this issue Jun 6, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants