Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

refactor tests use toBeUndefined() function instead of toBe(undefined) #14184

Closed
m-amr opened this issue Mar 6, 2016 · 0 comments
Closed

refactor tests use toBeUndefined() function instead of toBe(undefined) #14184

m-amr opened this issue Mar 6, 2016 · 0 comments

Comments

@m-amr
Copy link
Contributor

m-amr commented Mar 6, 2016

I am not sure if this important.

Note: for support questions, please use one of these channels: https://github.com/angular/angular.js/blob/master/CONTRIBUTING.md#question. This repository's issues are reserved for feature requests and bug reports.

  • Do you want to request a feature or report a bug?
    refactor tests Use toBeUndefined() function instead of toBe(undefined)
  • What is the current behavior?
    some tests use toBeUndefined() and other use toBe(undefined)
  • If the current behavior is a bug, please provide the steps to reproduce and if possible a minimal demo of the problem via
    https://plnkr.co or similar (you can use this template as a starting point: http://plnkr.co/edit/tpl:yBpEi4).
  • What is the expected behavior?
    use toBeUndefined() for all tests for code consistency
  • What is the motivation / use case for changing the behavior?

code consistency

  • Which version of Angular, and which browser and OS does this issue affect? Did this work in previous
    versions of Angular? Please also test with the latest stable and snapshot versions.
  • Other information (e.g. detailed explanation, stacktraces, related issues, suggestions how to fix)
m-amr added a commit to m-amr/angular.js that referenced this issue Mar 6, 2016
…nction

use toBeUndefined for code consistency
fixes angular#14184
m-amr added a commit to m-amr/angular.js that referenced this issue Mar 6, 2016
…nction

use toBeUndefined for code consistency
fixes angular#14184
petebacondarwin pushed a commit that referenced this issue Mar 7, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants
@m-amr and others