Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

fix(ngAria): don't attach roles to native controls #14076

Closed
gkalpak opened this issue Feb 18, 2016 · 0 comments
Closed

fix(ngAria): don't attach roles to native controls #14076

gkalpak opened this issue Feb 18, 2016 · 0 comments
Labels
component: ngAria frequency: low needs: breaking change PRs plz! severity: confusing type: bug
Milestone
Backlog - won't fix

Comments

@gkalpak
Copy link
Member

gkalpak commented Feb 18, 2016

Currently, ngAria doesn't attach roles to input elements, but it does so to other native controls (e.g. textarea, select, button etc). As discussed in #13483 (comment), it should only attach roles to non-native controls.

This is a slight BC (shouldn't affect A11Y, though).
@gkalpak gkalpak added this to the Backlog milestone Feb 18, 2016
@gkalpak gkalpak changed the title fix(ngAria): don't attach roles to native elements fix(ngAria): don't attach roles to native controls Feb 18, 2016
m-amr added a commit to m-amr/angular.js that referenced this issue Feb 27, 2016
@m-amr
fix(ngAria): don't attach roles to native controls
cb9498a 
don't add roles to (textarea, button, select, input)
fix angular#14076
@m-amr m-amr mentioned this issue Feb 27, 2016
Closed
3 tasks
m-amr added a commit to m-amr/angular.js that referenced this issue Feb 27, 2016
@m-amr
fix(ngAria): don't add roles to native elements
c88dff7 
don't add roles to (textarea, button, select, summary, details, a, input)
fix angular#14076
m-amr added a commit to m-amr/angular.js that referenced this issue Feb 27, 2016
@m-amr
fix(ngAria): don't add roles to native elements
c4b5cd9 
don't add roles to (textarea, button, select, summary, details, a, input)
fix angular#14076
m-amr added a commit to m-amr/angular.js that referenced this issue Feb 27, 2016
@m-amr
fix(ngAria): don't add roles to native elements
fc6e726 
don't add roles to (textarea, button, select, summary, details, a, input)
fix angular#14076
m-amr added a commit to m-amr/angular.js that referenced this issue Feb 28, 2016
@m-amr
fix(ngAria): don't add roles to native elements
b8f8822 
don't add roles to (textarea, button, select, summary, details, a, input)
fix angular#14076
m-amr added a commit to m-amr/angular.js that referenced this issue Feb 28, 2016
@m-amr
fix(ngAria): don't add roles to native elements
fed351a 
don't add roles to textarea, button, select, summary, details, a and input (albeit a small one that shouldn't affect a11y)
fix angular#14076
m-amr added a commit to m-amr/angular.js that referenced this issue Mar 30, 2016
@m-amr
fix(ngAria): don't add roles to native elements
7381a87 
don't add roles to textarea, button, select, summary, details, a and input
BREAKING CHANGE: albeit a small one that shouldn't affect a11y
Closes  angular#14076
m-amr added a commit to m-amr/angular.js that referenced this issue Mar 30, 2016
@m-amr
fix(ngAria): don't add roles to native elements
0eb5441 
don't add roles to textarea, button, select, summary, details, a and input

Closes  angular#14076
BREAKING CHANGE: albeit a small one that shouldn't affect a11y
m-amr added a commit to m-amr/angular.js that referenced this issue Mar 30, 2016
@m-amr
fix(ngAria): don't add roles to native elements
2f981b7 
don't add roles to textarea, button, select, summary, details, a and input

Closes  angular#14076
BREAKING CHANGE: albeit a small one that shouldn't affect a11y
m-amr added a commit to m-amr/angular.js that referenced this issue Mar 30, 2016
@m-amr
fix(ngAria): don't add roles to native elements
2d2af6b 
prevent ngAria from attaching roles to textarea, button, select, summary, details, a and input

Closes  angular#14076

BREAKING CHANGE:

Curreny behavior that ngAria don't attach roles to input elements but it does so to
other natve controls.
so this change will prevent ngAria from attaching roles to native
elements like (textrea, select, button, etc) and it will only attach roles to non-native
controls. and this should not affect accessibility, because native inputs are accessible
by default.
(albeit a small one that shouldn't affect a11y)
m-amr added a commit to m-amr/angular.js that referenced this issue Mar 30, 2016
@m-amr
fix(ngAria): don't add roles to native elements
e101e8d 
prevent ngAria from attaching roles to textarea, button, select, summary, details, a and input

Closes  angular#14076

BREAKING CHANGE:

Curreny behavior that ngAria don't attach roles to input elements but it does so to other natve controls.
so this change will prevent ngAria from attaching roles to native elements like (textrea, select, button, etc) and it will only attach roles to non-native
controls. and this should not affect accessibility, because native inputs are accessible by default.
(albeit a small one that shouldn't affect a11y)
m-amr added a commit to m-amr/angular.js that referenced this issue Mar 30, 2016
@m-amr
fix(ngAria): don't add roles to native elements
185b982 
prevent ngAria from attaching roles to textarea, button, select, summary, details, a and input

Closes  angular#14076

BREAKING CHANGE:

Curreny behavior is that ngAria don't attach roles to input elements but it does so to other natve controls.
so this change will prevent ngAria from attaching roles to native elements like (textrea, select, button, etc) and it will only attach roles to non-native controls.
and this should not affect accessibility, because native inputs are accessible by default.
(albeit a small one that shouldn't affect a11y)
m-amr added a commit to m-amr/angular.js that referenced this issue Apr 8, 2016
@m-amr
fix(ngAria): don't add roles to native elements
6fd9c76 
prevent ngAria from attaching roles to textarea, button, select, summary, details, a and input

Closes  angular#14076

BREAKING CHANGE:

Curreny behavior is that ngAria don't attach roles to input elements but it does so to other native controls.
so this change will prevent ngAria from attaching roles to native elements like (textrea, select, button, etc) and it will only attach roles to non-native controls.
and this should not affect accessibility, because native inputs are accessible by default.
(albeit a small one that shouldn't affect a11y)
@Narretz Narretz closed this as completed in 9978de1 Apr 8, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
component: ngAria frequency: low needs: breaking change PRs plz! severity: confusing type: bug
Projects
None yet
Milestone
Backlog - won't fix
Development

Successfully merging a pull request may close this issue.

fix(ngAria): don't attach roles to native controls m-amr/angular.js
1 participant
@gkalpak