Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

$compile: $document is unused #13791

Closed
dcherman opened this issue Jan 18, 2016 · 1 comment
Closed

$compile: $document is unused #13791

dcherman opened this issue Jan 18, 2016 · 1 comment
Labels
type: chore
Milestone
Backlog - won't fix

Comments

@dcherman
Copy link
Contributor

Currently, $document is injected into compile, however it is entirely unused; the global document is always referenced instead. Should the $document variable be used in all of these locations, or should we consider removing the $document dependency?

I'm happy to make a PR for whichever way you feel this should go.
@Narretz
Copy link
Contributor

Narretz commented Jan 19, 2016

I think it can be removed. It was added by 9532234 and it's only use finally removed by 9f4d99f

@Narretz Narretz added this to the Backlog milestone Jan 19, 2016
dcherman added a commit to dcherman/angular.js that referenced this issue Jan 19, 2016
@dcherman
chore($compile): remove an unused dependency
f316dbb 
Fixes angular#13791
@dcherman dcherman mentioned this issue Jan 19, 2016
Closed
gkalpak pushed a commit that referenced this issue Jan 19, 2016
@dcherman @gkalpak
chore($compile): remove an unused dependency
c429ad8 
Fixes #13791

Closes #13801
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
type: chore
Projects
None yet
Milestone
Backlog - won't fix
Development

No branches or pull requests
2 participants
@dcherman @Narretz