Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

Missing ">" in textarea closing tag in ngListSpec #13728

Closed
m-amr opened this issue Jan 9, 2016 · 2 comments
Closed

Missing ">" in textarea closing tag in ngListSpec #13728

m-amr opened this issue Jan 9, 2016 · 2 comments

Comments

@m-amr
Copy link
Contributor

m-amr commented Jan 9, 2016

I was debugging something in ngListSpec test and i found that

helper.compileInput('<textarea type="text" ng-model="list" ng-trim="false" ng-list="&#10;"></textarea');

Missing '>' and the textarea closing tag
@m-amr
Copy link
Contributor Author

m-amr commented Jan 9, 2016

I fixed it in this pull request #13727

@m-amr m-amr closed this as completed Jan 9, 2016
@m-amr m-amr reopened this Jan 9, 2016
@gkalpak
Copy link
Member

gkalpak commented Jan 10, 2016

@m-amr, (for future PRs) if you submit a PR that fixes a reported issue (even one reported by yourself), you should add Fixes #<issue-number> in the footer of the commit message.
Then the issue will be closed automatically once the PR is merged.

gkalpak pushed a commit that referenced this issue Jan 10, 2016
@m-amr @gkalpak
test(ngList): add missing '>' to textarea closing tag
7f1cd3e 
Fixes #13728
Closes #13727
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@m-amr @gkalpak