Uncaught ReferenceError: Node is not defined

[MaestroJurko]

angular.js:2789 Uncaught ReferenceError: Node is not defined

Updated from 1.4.7 to 1.4.8

[Narretz]

Please provide more context information; stacktrace, minimal demo etc.

[MaestroJurko]

This happens on specific d3 charts. Will try to create an example, but it works with 1.4.7 version. I see that there were some changes on jqlite. Probably that is the reason.

I am using jquery, did how to use jquery + angularjs changed?

[jlmitch5]

No coverage information was collected, exit without writing coverage information
/Users/jmitchell/tower_fork/node_modules/angular/angular.js:2789
var jqLiteContains = Node.prototype.contains || function(arg) {
                     ^

ReferenceError: Node is not defined
    at /Users/jmitchell/tower_fork/node_modules/angular/angular.js:2789:22
    at Object.<anonymous> (/Users/jmitchell/tower_fork/node_modules/angular/angular.js:29016:3)

It's happening after require("angular/angular"); in the traceback

Bumping angular to be specifically 1.4.7 fixes the issue.

[Narretz]

Ah, I see it's a change that has been made to jqlite which relies on Node. I'm not sure how that's fixable for server use of angular.

[Narretz]

Actually, how exactly do you use Angular with require? In the browser or on the server?

[jlmitch5]

@Narretz I inherited this flow, and I haven't dove too deep/know if its best practice, but we require angular when building the app for testing.

We take several client JS libraries through require, and then set up these to be found on window.

[neha-nsharma]

I am getting the same exception with the mocha tests after upgrading to angular 1.4.8

var jqLiteContains = Node.prototype.contains || function(arg) {
^
ReferenceError: Node is not defined
at .../angular/angular.js:2789:22

[Narretz]

@gkalpak ping because you committed the change that causes this. Do you think this is something we should account for?

[gkalpak]

Did I ? Let me take a closer look :)

[gkalpak]

I don't think I was involved with 941c1c3, which introduced this, but I think it is worth solving anyway...
The fix should be pretty simple too.

[Narretz]

@gkalpak Ah, sorry. But thanks for fixing it ;)

[Narretz]

@neha-nsharma: can you explain / show your setup? For example, Are you using a module loader or jsdom?

[neha-nsharma]

I am using jsdom (0.11.1 version); I have the issue running my mocha tests. I was able to make it work by setting Node = window.Node; in the mocha config.

Thank you,
Neha

On Dec 16, 2015, at 1:26 AM, Martin Staffa [email protected] wrote:

@neha-nsharma https://github.com/neha-nsharma: can you explain / show your setup? For example, Are you using a module loader or jsdom?

—
Reply to this email directly or view it on GitHub #13442 (comment).

[Narretz]

If you are using jsdom, it's your responsibility to provide the correct context. So I'd say this is not fixable in angular.

[gkalpak]

@neha-nesharma, does it mean that changing Node.prototype.contains to window.Node.prototype.contains in Angular solves the issue ?
That might be a reasonable change.

[neha-nsharma]

That is correct. This change will work.

Thank you

On Dec 17, 2015, at 7:45 AM, Georgios Kalpakas [email protected] wrote:

@neha-nesharma, does it mean that changing Node.prototype.contains to window.Node.prototype.contains in Angular solves the issue ?
That might be a reasonable change.

—
Reply to this email directly or view it on GitHub #13442 (comment).

[petebacondarwin]

@mgol is going to look into whether doing this comprehensively is feasible without too much work.

[simkessy]

When I change to window.Node.prototype.contains I now get the error Unable to get property 'prototype' of undefined or null reference

I'm using IE8 and trying to get angular running there.

[petebacondarwin]

@simkessy - Versions of Angular after 1.2 do not support IE8

[simkessy]

@petebacondarwin - thanks for the response. I've begun reverting back to 1.2 (unfortunately)

[MaestroJurko]

I am getting this issue in angular 1.5.3 version.

How to fix this?

Using jquery and d3.

[gkalpak]

@mato75, you need to make sure Node is available on the global context.

[MaestroJurko]

Ok, thank you, but why is not the fix included with new versions of Angular library?

[gkalpak]

@mato75, this doesn't break any of the "officially" supported browsers (and so far there hasn't been any report of an issue that couldn't be solved on the developer's side).

But we are investigating if/how we can fix this and other similar issues, so it is easier for people running their code/tests in other environments (e.g. jsdom). This is not a high priority though, so don't expect a quick turnaround.

[petebacondarwin]

@mato75 see #13442 (comment)

[mgol]

PR: #14345

[MaestroJurko]

@gkalpak changing Node.prototype to window.Node.prototype doesnt solve this issue. Angular 1.5.7 + jquery 2.1.3 + Latest Chrome.

[mgol]

@mato75 If window.Node.prototype doesn't exist for you in Chrome then something must be really weird with your setup. We'd have to see a reproducible example, we can't do anything here if we don't see the code.

[MaestroJurko]

Ah I see. It is a problem when using angularjs library in web worker.

[mgol]

That explains the problem. Angular 1 is not supported in Web Workers. What are you trying to do with Angular there? Since Web Workers don't have access to the DOM, most of the Angular functionality (directives/components, events, data binding etc.) disappears.