Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

How do you tell if an optional multi transclude property has been set? #13426

Closed
waeljammal opened this issue Dec 1, 2015 · 3 comments
Closed

How do you tell if an optional multi transclude property has been set? #13426

waeljammal opened this issue Dec 1, 2015 · 3 comments
Labels
component: $compile severity: inconvenient
Milestone
1.5.0-rc.0

Comments

@waeljammal
Copy link

Basically I can not find a way to check if an optional transclude was supplied, I want to show hide the parent based on the transclude being set or not.

If there is no way is it possible to get this added? It is a useful feature to along side optional transclude.

Thanks
@petebacondarwin
Copy link
Contributor

This is something that @PascalPrecht was asking for too, I think...

@petebacondarwin petebacondarwin added this to the 1.5.0-rc.0 milestone Dec 2, 2015
@petebacondarwin
Copy link
Contributor

A benefit of this would be that we could provide default content in ngTransclude for optional transclusion slots.

petebacondarwin added a commit to petebacondarwin/angular.js that referenced this issue Dec 2, 2015
@petebacondarwin
feat($compile): expose transclusion $$slots on the $transclude fu…
de26571 
…nction

Unfilled optional slots will exist as properties of `$$slots` but have a value of `null`.

Closes angular#13426
petebacondarwin added a commit to petebacondarwin/angular.js that referenced this issue Dec 2, 2015
@petebacondarwin
feat(ngTransclude): don't overwrite the contents with an unfilled opt…
74df9b4 
…ional slot

Previously the contents of the `ngTransclude` element would always be emptied,
even if there was no transclusion to replace it.
Now, optional slots that have not been filled with content will not cause
the `ngTransclude` contents to be emptied.

Closes angular#13426
petebacondarwin added a commit to petebacondarwin/angular.js that referenced this issue Dec 2, 2015
@petebacondarwin
feat($compile): expose transclusion $$slots on the $transclude fu…
4c6b500 
…nction

Unfilled optional slots will exist as properties of `$$slots` but have a value of `null`.

Closes angular#13426
@petebacondarwin
Copy link
Contributor

Here is a PR: #13431

@petebacondarwin petebacondarwin mentioned this issue Dec 2, 2015
Merged
petebacondarwin added a commit to petebacondarwin/angular.js that referenced this issue Dec 2, 2015
@petebacondarwin
feat($compile): expose transclusion $slots on the $transclude fun…
6d52396 
…ction

Unfilled optional slots will exist as properties of `$slots` but have a value of `null`.

Closes angular#13426
petebacondarwin added a commit to petebacondarwin/angular.js that referenced this issue Dec 2, 2015
@petebacondarwin
feat(ngTransclude): don't overwrite the contents with an unfilled opt…
b4fc2f7 
…ional slot

Previously the contents of the `ngTransclude` element would always be emptied,
even if there was no transclusion to replace it.
Now, optional slots that have not been filled with content will not cause
the `ngTransclude` contents to be emptied.

Closes angular#13426
petebacondarwin added a commit to petebacondarwin/angular.js that referenced this issue Dec 4, 2015
@petebacondarwin
feat($compile): expose transclusion $slots on the $transclude fun…
0c858b0 
…ction

Unfilled optional slots will exist as properties of `$slots` but have a value of `null`.

Closes angular#13426
petebacondarwin added a commit to petebacondarwin/angular.js that referenced this issue Dec 4, 2015
@petebacondarwin
feat(ngTransclude): don't overwrite the contents with an unfilled opt…
e2dbea1 
…ional slot

Previously the contents of the `ngTransclude` element would always be emptied,
even if there was no transclusion to replace it.
Now, optional slots that have not been filled with content will not cause
the `ngTransclude` contents to be emptied.

Closes angular#13426
petebacondarwin added a commit to petebacondarwin/angular.js that referenced this issue Dec 4, 2015
@petebacondarwin
feat($compile): expose transclusion $slots on the $transclude fun…
7f3d5f9 
…ction

Unfilled optional slots will exist as properties of `$slots` but have a value of `null`.

Closes angular#13426
petebacondarwin added a commit to petebacondarwin/angular.js that referenced this issue Dec 4, 2015
@petebacondarwin
feat(ngTransclude): don't overwrite the contents with an unfilled opt…
4785304 
…ional slot

Previously the contents of the `ngTransclude` element would always be emptied,
even if there was no transclusion to replace it.
Now, optional slots that have not been filled with content will not cause
the `ngTransclude` contents to be emptied.

Closes angular#13426
petebacondarwin added a commit to petebacondarwin/angular.js that referenced this issue Dec 4, 2015
@petebacondarwin
feat(ngTransclude): don't overwrite the contents with an unfilled opt…
0812af4 
…ional slot

Previously the contents of the `ngTransclude` element would always be emptied,
even if there was no transclusion to replace it.
Now, optional slots that have not been filled with content will not cause
the `ngTransclude` contents to be emptied.

Closes angular#13426
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
component: $compile severity: inconvenient
Projects
None yet
Milestone
1.5.0-rc.0
Development

No branches or pull requests
3 participants
@petebacondarwin @waeljammal @Narretz