Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

Weird example of string interpolation in directives guide #1339

Closed
btford opened this issue Sep 6, 2012 · 5 comments
Closed

Weird example of string interpolation in directives guide #1339

btford opened this issue Sep 6, 2012 · 5 comments

Comments

@btford
Copy link
Contributor

btford commented Sep 6, 2012

In the developer guide for directives, the string interpolation example is odd.

<img src="img/{{username}}.jpg">Hello {{username}}!</img>

I would expect:

<img src="img/{{username}}.jpg">

and/or:

<p>Hello {{username}}!</p>
@mernen
Copy link
Contributor

mernen commented Sep 7, 2012

Also, wouldn't <img src> be a bad example? (as explained in ng-src's docs)

@btford
Copy link
Contributor Author

btford commented Sep 7, 2012

Yes, that too.

@btford
Copy link
Contributor Author

btford commented Sep 7, 2012

I opted for just:

<p>Hello {{username}}!</p>

@mhevery
Copy link
Contributor

mhevery commented Sep 7, 2012

That should have been

will fix

On Thu, Sep 6, 2012 at 9:19 PM, Brian Ford [email protected] wrote:

I opted for just:

Hello {{username}}!


Reply to this email directly or view it on GitHubhttps://github.com//issues/1339#issuecomment-8355609.

btford added a commit to btford/angular.js that referenced this issue Sep 8, 2012
@btford
Copy link
Contributor Author

btford commented Sep 8, 2012

I fixed my PR.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants