Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

Unused function $$AsyncCallbackProvider #12371

Closed
alexlamsl opened this issue Jul 17, 2015 · 5 comments
Closed

Unused function $$AsyncCallbackProvider #12371

alexlamsl opened this issue Jul 17, 2015 · 5 comments

Comments

@alexlamsl
Copy link

After #12254 and #12251, src/ng/asyncCallback.js seems to contain only dead code
@mgol
Copy link
Member

mgol commented Jul 17, 2015

D'oh, how did I miss that. Do you want to submit a PR?

@alexlamsl
Copy link
Author

I don't have AngularJS codebase set up to do PRs properly, sorry.

Only spotted this whilst auditing the changes on angular.js between 1.4.2 & 1.4.3

@lgalfaso
Copy link
Contributor

@alexlamsl thanks for reporting this. A fix landed with 8ed6829

@alexlamsl
Copy link
Author

I am not familiar enough with the build to be sure, but does this line need to be removed as well?

@lgalfaso
Copy link
Contributor

@alexlamsl you are right. Thanks!

netman92 pushed a commit to netman92/angular.js that referenced this issue Aug 8, 2015
@lgalfaso @netman92
chore(asyncCallback): Remove dead code
9084ff2 
Closes angular#12371
ggershoni pushed a commit to ggershoni/angular.js that referenced this issue Sep 29, 2015
@lgalfaso
chore(asyncCallback): Remove dead code
0971a50 
Closes angular#12371
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@lgalfaso @mgol @alexlamsl