Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

Animation issue on Android 4.1.2. #12187

Closed
mdudek opened this issue Jun 22, 2015 · 26 comments
Closed

Animation issue on Android 4.1.2. #12187

mdudek opened this issue Jun 22, 2015 · 26 comments
Assignees
Milestone

Comments

@mdudek
Copy link

mdudek commented Jun 22, 2015

Hi,

I'm facing issue regarding angular animations in my Cordova app running on Android 4.1.2. It happen time to time, its hard to reproduce and I don't know what it could be caused by. I have tried both versions of Angular (1.3.16 and 1.4)

Here is stacktrace:

Details:Cannot set property 'WebkitTransitionProperty' of undefined: TypeError: Cannot set property 'WebkitTransitionProperty' of undefined
    at blockTransitions (file:///android_asset/www/js/lib/angular-animate.js:1982:70)
    at animateSetup (file:///android_asset/www/js/lib/angular-animate.js:1813:11)
    at animateBefore (file:///android_asset/www/js/lib/angular-animate.js:1990:13)
    at Object.beforeAddClass [as fn] (file:///android_asset/www/js/lib/angular-animate.js:2086:36)
    at file:///android_asset/www/js/lib/angular-animate.js:741:46
    at forEach (file:///android_asset/www/js/lib/angular.js:326:20)
    at run (file:///android_asset/www/js/lib/angular-animate.js:729:11)
    at Object.before (file:///android_asset/www/js/lib/angular-animate.js:770:13)
    at performAnimation (file:///android_asset/www/js/lib/angular-animate.js:1413:16)
    at file:///android_asset/www/js/lib/angular-animate.js:1219:17

Dont you have and idea what could be wrong with it? Thanks for help.

@matsko
Copy link
Contributor

matsko commented Jun 22, 2015

Maybe it's attempting to animate a comment node or a non-element node somehow? Is there anyway you could do a console.log(node) for the node in that function (blockTransitions)?

@matsko matsko self-assigned this Jun 22, 2015
@mdudek
Copy link
Author

mdudek commented Jun 22, 2015

This issue is reported by our external tester, I will modify angular-animate.js with this logging and create special app version for him. We will hopefully get better info about related node.

@Narretz Narretz added this to the 1.4.2 milestone Jun 24, 2015
@petebacondarwin petebacondarwin modified the milestones: 1.4.2, 1.4.3 Jul 6, 2015
@matsko matsko modified the milestones: 1.4.3, 1.4.4 Jul 14, 2015
@matsko
Copy link
Contributor

matsko commented Jul 15, 2015

Would you mind testing this out on the latest version of Angular?

@matsko
Copy link
Contributor

matsko commented Jul 17, 2015

Could you test this out on 1.4.3 or snapshot?
https://code.angularjs.org/1.4.3/angular-animate.js
https://code.angularjs.org/snapshot/angular-animate.js

We fixed a few issues with the node being deleted during an animation. Perhaps this also fixed this issue.

@mdudek
Copy link
Author

mdudek commented Jul 20, 2015

ok, we will try v1.4.3, if its fixed...

@matsko
Copy link
Contributor

matsko commented Jul 28, 2015

Any luck?

@mdudek
Copy link
Author

mdudek commented Jul 29, 2015

It looks good, no issues reported after two days of testing. But it needs more time to finally confirm that its fixed, because this issue happen time to time.

@matsko
Copy link
Contributor

matsko commented Jul 29, 2015

Sure thing.

@mdudek
Copy link
Author

mdudek commented Aug 12, 2015

I got similar exception from tester today:

Details:Cannot set property 'WebkitTransitionDelay' of undefined

Stack:TypeError: Cannot set property 'WebkitTransitionDelay' of undefined
    at applyInlineStyle (file:///android_asset/www/js/lib/angular-animate.js:689:20)
    at blockTransitions (file:///android_asset/www/js/lib/angular-animate.js:675:3)
    at applyBlocking (file:///android_asset/www/js/lib/angular-animate.js:1094:11)
    at init (file:///android_asset/www/js/lib/angular-animate.js:1018:7)
    at prepareRegularAnimation (file:///android_asset/www/js/lib/angular-animate.js:1537:22)
    at initDriverFn (file:///android_asset/www/js/lib/angular-animate.js:1321:13)
    at invokeFirstDriver (file:///android_asset/www/js/lib/angular-animate.js:2911:24)
    at triggerAnimationStart (file:///android_asset/www/js/lib/angular-animate.js:2763:31)
    at runNextTask (file:///android_asset/www/js/lib/angular-animate.js:313:5)
    at nextTick (file:///android_asset/www/js/lib/angular-animate.js:297:7)

@Narretz Narretz modified the milestones: 1.4.4, 1.4.5 Aug 14, 2015
@matsko
Copy link
Contributor

matsko commented Aug 14, 2015

@mdudek we just released 1.4.4 with some nice fixes for ngAnimate. Would you mind testing against that one?

@mdudek
Copy link
Author

mdudek commented Aug 21, 2015

@matsko we just downloaded 1.4.4, but I found that css animations are completely broken ! I have checked that animations worked in previous 1.4.3. Its really big issue.

@matsko
Copy link
Contributor

matsko commented Aug 25, 2015

@mdudek I'm sorry to hear that. Can you test against these files:
http://www.angular-dev.com/raf-fix/angular.js
http://www.angular-dev.com/raf-fix/angular-animate.js

There's a fix in here that will be applied to 1.4.5.

@mdudek
Copy link
Author

mdudek commented Aug 25, 2015

@matsko Thanks for fix, animations works perfectly with this build. We will test 'WebkitTransitionDelay' related issue against this build. When we could expect stable release of 1.4.5?

@matsko
Copy link
Contributor

matsko commented Aug 25, 2015

Awesome. Later this week.

@matsko
Copy link
Contributor

matsko commented Aug 25, 2015

1.4.5 will come out then.

@Narretz Narretz modified the milestones: 1.4.6, 1.4.5 Aug 31, 2015
@petebacondarwin petebacondarwin modified the milestones: 1.4.6, 1.4.7 Sep 17, 2015
@Narretz Narretz modified the milestones: 1.4.7, 1.4.8 Oct 1, 2015
@Narretz Narretz modified the milestones: 1.4.8, 1.4.9 Nov 26, 2015
@petebacondarwin petebacondarwin modified the milestones: 1.4.9, 1.4.10 Jan 21, 2016
@petebacondarwin petebacondarwin modified the milestones: 1.4.10, 1.5.1 Jan 28, 2016
@Narretz Narretz modified the milestones: 1.5.x, 1.5.1 Feb 15, 2016
@Narretz
Copy link
Contributor

Narretz commented Apr 26, 2017

I'm going to close this issue because we have no reproduction of the issue. Feel free to reopen this issue if you can provide a reproduction (ideally a runnable demo in a Plunker or similar. You can use this Plunker Template).

@Narretz Narretz closed this as completed Apr 26, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants