This repository was archived by the owner on Apr 12, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 27.4k
Weird behavior of $animateCss with ng-if and quick toggling of elements in 1.4.0rc1 #11723
Labels
Milestone
Comments
JSFiddle showing the problem http://jsfiddle.net/z8gtkpzd/ - spam-click on the CLICK |
Did this work in 1.3.x? |
There is no |
matsko
added a commit
to matsko/angular.js
that referenced
this issue
May 5, 2015
…ion is closed Closes angular#11723
matsko
added a commit
to matsko/angular.js
that referenced
this issue
May 5, 2015
…ion is closed In the post-quiet animation detection phase of $animateCss there is a call to getComputedStyle which is cached, however, the cache is not cleared until the next animation is run. This causes a caching issue since the next animation's cache data may be read and provided incorrectly. This patch clears the cache after each animation has closed itself. Closes angular#11723
This was definitely a bug. Thank you for finding it. This PR will fix the issue: Also note that there is another PR which makes using |
matsko
added a commit
to matsko/angular.js
that referenced
this issue
May 5, 2015
…ion is closed In the post-quiet animation detection phase of $animateCss there is a call to getComputedStyle which is cached, however, the cache is not cleared until the next animation is run. This causes a caching issue since the next animation's cache data may be read and provided incorrectly. This patch clears the cache after each animation has closed itself. Closes angular#11723
matsko
added a commit
to matsko/angular.js
that referenced
this issue
May 11, 2015
matsko
added a commit
to matsko/angular.js
that referenced
this issue
May 22, 2015
netman92
pushed a commit
to netman92/angular.js
that referenced
this issue
Aug 8, 2015
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Angular version 1.4.0rc1
I wrote a custom javascript animation and applied it to
ng-if
:Simple behavior is correct when you toggle an item, it slides down and if you click again in the middle of the animation it slides back from the same position. But if you click yet again for it mid-animation to slide down ng-if creates a new DOM content and weirdly enough old DOM content starts animating down along with the new content. Is this expected behavior? Do you know of a workaround?
The text was updated successfully, but these errors were encountered: