Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

Git repository is missing .gitattributes file #10431

Closed
FarSeeing opened this issue Dec 12, 2014 · 1 comment
Closed

Git repository is missing .gitattributes file #10431

FarSeeing opened this issue Dec 12, 2014 · 1 comment
Assignees
@pkozlowski-opensource
Labels
type: chore
Milestone
1.4.0-beta.0

Comments

@FarSeeing
Copy link
Contributor

Since JSCS is used to check line endings in .js files, building on Windows fails if your have just autocrlf option, so you need to specify line endings in .gitattributes file.
@pkozlowski-opensource
Copy link
Member

I think I saw this on Win, indeed. We should probably fix it to make it easier to contribute for people who are Win.

@pkozlowski-opensource pkozlowski-opensource added this to the 1.3.8 milestone Dec 14, 2014
@pkozlowski-opensource pkozlowski-opensource self-assigned this Dec 17, 2014
@btford btford modified the milestones: 1.3.8, 1.3.9 Dec 19, 2014
FarSeeing added a commit to FarSeeing/angular.js that referenced this issue Dec 23, 2014
@FarSeeing
Chore: add .gitattributes file
4153e94 
Specify line endings for Windows builds.

Closes angular#10431
@FarSeeing FarSeeing mentioned this issue Dec 23, 2014
Closed
FarSeeing added a commit to FarSeeing/angular.js that referenced this issue Dec 23, 2014
@FarSeeing
chore: add .gitattributes file
7934adb 
Specify line endings for Windows builds.

Closes angular#10431
FarSeeing added a commit to FarSeeing/angular.js that referenced this issue Dec 30, 2014
@FarSeeing
chore: add .gitattributes file
af288a3 
Specify line endings for Windows builds.

Closes angular#10431
FarSeeing added a commit to FarSeeing/angular.js that referenced this issue Dec 30, 2014
@FarSeeing
chore: borrow .gitattributes file from jQuery.
0e72a76 
Specify line endings for Windows builds.

Closes angular#10431
FarSeeing added a commit to FarSeeing/angular.js that referenced this issue Dec 30, 2014
@FarSeeing
chore: add .gitattributes file
7b7d3a0 
Specify line endings for Windows builds.

Closes angular#10431
@FarSeeing FarSeeing reopened this Dec 30, 2014
FarSeeing added a commit to FarSeeing/angular.js that referenced this issue Dec 30, 2014
@FarSeeing
chore: borrow .gitattributes file from jQuery.
9c9c7ef 
Specify line endings for Windows builds.

Closes angular#10431
@FarSeeing FarSeeing mentioned this issue Dec 30, 2014
Closed
FarSeeing added a commit to FarSeeing/angular.js that referenced this issue Dec 30, 2014
@FarSeeing
chore: borrow .gitattributes file from jQuery
6f070b0 
Specify line endings for Windows builds.

Closes angular#10431
@PatrickJS PatrickJS mentioned this issue Jan 4, 2015
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@pkozlowski-opensource pkozlowski-opensource

Labels
type: chore
Projects
None yet
Milestone
1.4.0-beta.0
3 participants
@btford @FarSeeing @pkozlowski-opensource