max validator of input element do not work as expected on some cases #10307

tobyee · 2014-12-03T11:00:07Z

Demo Html, or view it on Plunker

<!DOCTYPE html>
<html lang="en">
<head>
    <title></title>
    <meta http-equiv="content-type" content="text/html;charset=UTF-8" />
    <script src="//ajax.googleapis.com/ajax/libs/angularjs/1.3.5/angular.min.js"></script>
    <script>
        angular.module("foo", []).controller("fooCtrl", function ($scope) {
            $scope.limit3 = 2;
        });
    </script>
    <style>
        input.ng-invalid {
            background-color: red;
        }
    </style>
</head>
<body ng-app="foo">
    <label>Form 1</label>
    <form action="/" method="post">
        <!--no controller-->
        <input type="number" ng-model="limit1" placeholder="limit" />
        <input type="number" max="{{limit1}}" ng-model="used1" placeholder="used" />
    </form>
    <br />
    <label>Form 2</label>
    <form action="/" method="post">
        <!--no controller, use ng-init directive-->
        <input type="number" ng-init="limit2=2" ng-model="limit2" placeholder="limit" />
        <input type="number" max="{{limit2}}" ng-model="used2" placeholder="used" />
    </form>
    <br />
    <label>Form 3</label>
    <form action="/" method="post" ng-controller="fooCtrl">
        <!--has controller-->
        <input type="number" ng-model="limit3" placeholder="limit" />
        <input type="number" max="{{limit3}}" ng-model="used3" placeholder="used" />
    </form>
</body>
</html>

Result:

The problem if that form 1 can not detect the max error.
This issue was found in both 1.2.x and 1.3.x.
I haven't test the other validators, such as min, max-length, may be there are some problem.

gkalpak · 2014-12-03T12:07:26Z

The problem seems to be at L1253 (if (attr.max || attr.ngMax) {), were we should be checking if attr.max/ngMax are defined (not truthy).

Interestingly enough, we are (almost) doing the right thing at L1179 for the date input (if (isDefined(attr.max) || attr.ngMax) {); at least for the max attribute.

Narretz · 2014-12-04T13:34:58Z

Does one of you fancy sending a PR?

…ue is - fix issue angular#10307 - change tests to corresponding changes - also change tests for ngmax and ngmin (though they have no some issue) Closes angular#10307

Also adds corresponding tests for ngMin / ngMax. Fixes #10307 Closes #10327

Narretz added component: forms type: bug severity: broken expected use frequency: low labels Dec 4, 2014

Narretz added this to the 1.3.x milestone Dec 4, 2014

tobyee added a commit to tobyee/angular.js that referenced this issue Dec 4, 2014

fix issue angular#10307

41743ef

tobyee mentioned this issue Dec 4, 2014

fix(input): create max and/or min validation whatever the initial value is #10327

Closed

Narretz closed this as completed in c211e7a Feb 10, 2015

Narretz pushed a commit that referenced this issue Feb 10, 2015

fix(input): create max and/or min validator regardless of initial value

abfce53

Also adds corresponding tests for ngMin / ngMax. Fixes #10307 Closes #10327

kkirsche mentioned this issue Feb 25, 2015

Update AngularJS to 1.3.14 cmar/rubyloco.com#2

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

max validator of input element do not work as expected on some cases #10307

max validator of input element do not work as expected on some cases #10307

tobyee commented Dec 3, 2014

gkalpak commented Dec 3, 2014

Narretz commented Dec 4, 2014

max validator of input element do not work as expected on some cases #10307

max validator of input element do not work as expected on some cases #10307

Comments

tobyee commented Dec 3, 2014

gkalpak commented Dec 3, 2014

Narretz commented Dec 4, 2014