Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

Awkward wording on ngBindHtml reference page #10097

Closed
LegalizeAdulthood opened this issue Nov 17, 2014 · 1 comment
Closed

Awkward wording on ngBindHtml reference page #10097

LegalizeAdulthood opened this issue Nov 17, 2014 · 1 comment
Labels
component: misc core PRs plz! type: docs
Milestone
Backlog - won't fix

Comments

@LegalizeAdulthood
Copy link
Contributor

ngBindHtml starts out by saying:

Creates a binding that will innerHTML the result of evaluating the expression into the current element in a secure way.

"Creates a binding that will innerHTML"? innerHTML isn't a verb, so this doesn't read well. It should probably be changed to language more like ngBind

The ngBindHtml attribute tells Angular to replace the inner HTML content of the specified HTML element with the value of a given expression, and to update the inner HTML content when the value of that expression changes.
@pkozlowski-opensource
Copy link
Member

@LegalizeAdulthood would you mind sending us a pull request with the proposed change?

@pkozlowski-opensource pkozlowski-opensource added this to the Backlog milestone Nov 17, 2014
@trizko trizko mentioned this issue Nov 18, 2014
Closed
trizko added a commit to trizko/angular.js that referenced this issue Nov 19, 2014
@trizko
docs(ngBindHtml): fix awkward wording
7bbd6af 
for issue angular#10097

changes:
/**
 * @ngdoc directive
 * @name ngBindHtml
 *
 * @description
 * Creates a binding that will innerHTML the result of evaluating the `expression` into the current
 * element in a secure way.  By default, the innerHTML-ed content will be sanitized using the {@link
 * ngSanitize.$sanitize $sanitize} service.  To utilize this functionality, ensure that `$sanitize`

to this:
/**
 * @ngdoc directive
 * @name ngBindHtml
 *
 * @description
 * Evaluates the expression and inserts the resulting HTML into the element in a secure way. By default, 
 * the resulting HTML content will be sanitized using the {@link ngSanitize.$sanitize $sanitize} service.
@trizko trizko mentioned this issue Nov 19, 2014
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
component: misc core PRs plz! type: docs
Projects
None yet
Milestone
Backlog - won't fix
Development

No branches or pull requests
2 participants
@pkozlowski-opensource @LegalizeAdulthood