review comments

Author: Narretz

src/ng/directive/ngRef.js

@@ -244,7 +244,7 @@ var ngRefMinErr = minErr('ngRef');
 
 var ngRefDirective = ['$parse', function($parse) {
   return {
-    priority: -1,
+    priority: -1, // Needed for compatibility with transclusion
     restrict: 'A',
     compile: function(tElement, tAttrs) {
       // Get the expected controller name, converts <data-some-thing> into "someThing"
@@ -258,35 +258,34 @@ var ngRefDirective = ['$parse', function($parse) {
 
       return function(scope, element, attrs) {
         var refValue;
-        var controller;
 
-        if ('ngRefRead' in attrs) {
+        if (attrs.hasOwnProperty('ngRefRead')) {
           if (attrs.ngRefRead === '$element') {
             refValue = element;
           } else {
-            controller = element.data('$' + attrs.ngRefRead + 'Controller');
-            if (!controller) {
+            refValue = element.data('$' + attrs.ngRefRead + 'Controller');
+
+            if (!refValue) {
               throw ngRefMinErr(
                 'noctrl',
                 'The controller for ngRefRead="{0}" could not be found on ngRef="{1}"',
                 attrs.ngRefRead,
                 tAttrs.ngRef
               );
             }
-
           }
         } else {
-          controller = element.data('$' + controllerName + 'Controller');
+          refValue = element.data('$' + controllerName + 'Controller');
         }
 
-        refValue = refValue || controller || element;
+        refValue = refValue || element;
 
         setter(scope, refValue);
 
         // when the element is removed, remove it (nullify it)
         element.on('$destroy', function() {
           // only remove it if value has not changed,
-          // carefully because animations (and other procedures) may duplicate elements
+          // because animations (and other procedures) may duplicate elements
           if (getter(scope) === refValue) {
             setter(scope, null);
           }