pete's comments

Author: Narretz

docs/content/error/ngRef/nonassign.ngdoc

@@ -19,7 +19,7 @@ For example, the following expressions are non-assignable:
 
 ```
 
-To resolve this error, use a path expression that are assignable:
+To resolve this error, use a path expression that is assignable:
 
 ```
 <my-directive ng-ref="$ctrl.reference"></my-directive>

src/ng/directive/ngRef.js

@@ -6,9 +6,9 @@
  * @restrict A
  *
  * @description
- * The `ngRef` attribute tells AngularJS to assign the controller of a component (or an element-directive)
- * to the given property in the current scope. If no controller exists, the jqlite-wrapped DOM
- * element will be added to the scope.
+ * The `ngRef` attribute tells AngularJS to assign the controller of a component (or a directive)
+ * to the given property in the current scope. It is also possible to add the jqlite-wrapped DOM
+ * element to the scope.
  *
  * If the element with `ngRef` is destroyed `null` is assigned to the property.
  *

test/ng/directive/ngRefSpec.js

@@ -4,7 +4,7 @@ describe('ngRef', function() {
 
   describe('on a component', function() {
 
-    var myComponentController, $rootScope, $compile;
+    var myComponentController, attributeDirectiveController, $rootScope, $compile;
 
     beforeEach(module(function($compileProvider) {
       $compileProvider.component('myComponent', {
@@ -13,6 +13,16 @@ describe('ngRef', function() {
           myComponentController = this;
         }
       });
+
+      $compileProvider.directive('attributeDirective', function() {
+        return {
+          restrict: 'A',
+          controller: function() {
+            attributeDirectiveController = this;
+          }
+        };
+      });
+
     }));
 
     beforeEach(inject(function(_$compile_, _$rootScope_) {
@@ -23,9 +33,9 @@ describe('ngRef', function() {
     it('should bind in the current scope the controller of a component', function() {
       $rootScope.$ctrl = 'undamaged';
 
-      $compile('<my-component ng-ref="myComponent"></my-component>')($rootScope);
+      $compile('<my-component ng-ref="myComponentRef"></my-component>')($rootScope);
       expect($rootScope.$ctrl).toBe('undamaged');
-      expect($rootScope.myComponent).toBe(myComponentController);
+      expect($rootScope.myComponentRef).toBe(myComponentController);
     });
 
     it('should throw if the expression is not assignable', function() {
@@ -59,6 +69,11 @@ describe('ngRef', function() {
       expect($rootScope.myComponent2).toBe(myComponentController);
     });
 
+    it('should not bind the controller of an attribute directive', function() {
+      $compile('<my-component attribute-directive-1 ng-ref="myComponentRef"></my-component>')($rootScope);
+      expect($rootScope.myComponentRef).toBe(myComponentController);
+    });
+
     it('should not leak to parent scopes', function() {
       var template =
         '<div ng-if="true">' +
@@ -116,7 +131,7 @@ describe('ngRef', function() {
     expect($rootScope.mySpan[0].textContent).toBe('my text');
   }));
 
-  it('should nullify the dom element value if it is destroyed', inject(function($compile, $rootScope) {
+  it('should nullify the expression value if the DOM element is destroyed', inject(function($compile, $rootScope) {
     var element = $compile('<div><span ng-ref="mySpan">my text</span></div>')($rootScope);
     element.children().remove();
     expect($rootScope.mySpan).toBe(null);
@@ -185,7 +200,7 @@ describe('ngRef', function() {
 
 
     it('should bind an attribute-directive controller if ngRefRead="controllerName" is set', function() {
-      var attrDirective2Controller;
+      var attrDirective1Controller;
 
       module(function($compileProvider) {
         $compileProvider.directive('elementDirective', function() {
@@ -200,7 +215,7 @@ describe('ngRef', function() {
           return {
             restrict: 'A',
             controller: function() {
-              attrDirective2Controller = this;
+              attrDirective1Controller = this;
             }
           };
         });
@@ -221,7 +236,7 @@ describe('ngRef', function() {
           'ng-ref="myController"' +
           'ng-ref-read="$element"></element-directive>')($rootScope);
 
-        expect($rootScope.myController).toBe(attrDirective2Controller);
+        expect($rootScope.myController).toBe(attrDirective1Controller);
       });
     });