Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

Commit 0256df7

Browse files
committed
fixup! fix($compile): use correct parent element when requiring on html element
1 parent 874cd3d commit 0256df7

File tree

2 files changed

+10
-2
lines changed

2 files changed

+10
-2
lines changed

test/e2e/fixtures/directive-require-html/script.js

+9-1
Original file line numberDiff line numberDiff line change
@@ -2,11 +2,19 @@
22

33
angular.
44
module('test', []).
5+
provider('$exceptionHandler', /** @this */ function() {
6+
this.$get = [function() {
7+
return function(error) {
8+
window.document.querySelector('#container').textContent = error && error.message;
9+
};
10+
}];
11+
}).
12+
513
directive('requireDirective', function() {
614
return {
715
require: '^^requireTargetDirective',
816
link: function(scope, element, attrs, ctrl) {
9-
window.document.querySelector('#container').append(window.document.createTextNode(ctrl.content));
17+
window.document.querySelector('#container').textContent = ctrl.content;
1018
}
1119
};
1220
}).

test/e2e/tests/directive-require-html.spec.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,6 @@ describe('require parent controller on html element', function() {
55

66
loadFixture('directive-require-html');
77

8-
expect(element(by.id('container')).getText()).not.toContain('requiredContent');
8+
expect(element(by.id('container')).getText()).toContain('Controller \'requireTargetDirective\', required by directive \'requireDirective\', can\'t be found!');
99
});
1010
});

0 commit comments

Comments
 (0)