fixup! fix($compile): use correct parent element when requiring on html element

Narretz · Narretz · commit 874cd3d40e45 · 2018-07-27T13:36:57.000+02:00
diff --git a/test/e2e/fixtures/directive-require-html/index.html b/test/e2e/fixtures/directive-require-html/index.html
@@ -1,6 +1,7 @@
 <!DOCTYPE html>
 <html ng-app="test" require-directive require-target-directive>
   <body>
+    <div id="container"></div>
     <script src="angular.js"></script>
     <script src="script.js"></script>
   </body>
diff --git a/test/e2e/fixtures/directive-require-html/script.js b/test/e2e/fixtures/directive-require-html/script.js
@@ -5,12 +5,16 @@ angular.
   directive('requireDirective', function() {
     return {
       require: '^^requireTargetDirective',
-      link: function() {}
+      link: function(scope, element, attrs, ctrl) {
+        window.document.querySelector('#container').append(window.document.createTextNode(ctrl.content));
+      }
     };
   }).
   directive('requireTargetDirective', function() {
     return {
-      controller: function() {}
+      controller: function() {
+        this.content = 'requiredContent';
+      }
     };
   });
 
diff --git a/test/e2e/tests/directive-require-html.spec.js b/test/e2e/tests/directive-require-html.spec.js
@@ -5,13 +5,6 @@ describe('require parent controller on html element', function() {
 
     loadFixture('directive-require-html');
 
-    browser.manage().logs().get('browser').then(function(browserLogs) {
-      var requireError = browserLogs.find(function(log) {
-        return log.message.indexOf('Controller \'requireTargetDirective\', required by directive \'requireDirective\', can\'t be found!') > -1;
-      });
-
-      expect(requireError).toBeDefined();
-      expect(requireError.level.value).toBe(1000);
-    });
+    expect(element(by.id('container')).getText()).not.toContain('requiredContent');
   });
 });
