This repository was archived by the owner on Dec 4, 2017. It is now read-only.

Content edits in the Angular 2 Guide. #3159

Merged

juleskremer merged 7 commits into angular:master from IdeaBlade:cf-edits

Mar 1, 2017

Contributor

cfranger commented Jan 28, 2017

@juleskremer Here are my edits to the "Forms" page.


          Content edits in the Angular 2 "Forms" page.

9615e59

googlebot added the CLA: yes label

juleskremer reviewed

View reviewed changes

public/docs/ts/latest/guide/forms.jade Outdated

+                 scope for this page), as well as framework support for
+                 *two-way data binding, change tracking, validation, and error handling*,
+                 which you'll learn about on this page."
+                 -->

Contributor

juleskremer Jan 28, 2017

yes please

juleskremer reviewed

View reviewed changes

public/docs/ts/latest/guide/forms.jade Outdated

               .l-sub-section
                 :marked
-                  That's not the only way to create a form but it's the way we'll cover in this guide.
+                  That's not the only way to create a form but it's the way that's covered in this page.
+              //    CF: Is this note necessary?

Contributor

juleskremer Jan 28, 2017 •

edited

Loading

It is but it should be more descriptive that there two choices: template-driven and reactive and that this guide focuses on template-driven forms.


          Updates based on @juleskremer's feedback.

5633ead

Contributor Author

cfranger commented Feb 2, 2017

@juleskremer thanks for your comments. I committed some updates based on your feedback. I have a few more questions in the page--please search for "CF:"

cfranger added 2 commits

February 2, 2017 13:52


          Added bold formatting for UI button names.

a2cf9ce


          [WIP] Copyedits to the Glossary. Includes several questions and comme…

7bf716b

…nts--search for "CF:"

Contributor Author

cfranger commented Feb 3, 2017

@juleskremer My latest commit is an edit of the Glossary page. I added several comments with questions. Search for "CF:". Thanks!

juleskremer reviewed

View reviewed changes

public/docs/ts/latest/glossary.jade Outdated

                   the component class, thereby attaching to the class the essential component metadata
                   that Angular needs to create a component instance and render it with its template
                   as a view.
+                  <!-- CF: What do "it" and "its" refer to? The component class, component metadata, or component instance? -->

Contributor

juleskremer Feb 20, 2017

the component with it's template.

public/docs/ts/latest/glossary.jade Outdated

@@ @@ -164,7 +166,10 @@ a#aot @@
               .l-sub-section
                 :marked
                   The practice of writing compound words or phrases such that each word is separated by a dash or hyphen (`-`).
-                  This form is also known as [kebab-case](#kebab-case).
+                  This form is also known as kebab-case.
+                  <!-- CF: I removed the link to the kebab-case glossary entry because the entry has no additional

Contributor

juleskremer Feb 20, 2017

lgtm

public/docs/ts/latest/glossary.jade Outdated

                   Angular provides and relies upon its own sophisticated
-                  [dependency injection](!{docsLatest}/guide/dependency-injection.html) system
+                  dependency-injection system
+                  <!-- CF: I removed the link here because the same link is at the end of this definition. -->

Contributor

juleskremer Feb 20, 2017

lgtm

public/docs/ts/latest/glossary.jade Outdated

-                  A service is a class with a focused purpose.
-                  We often create a service to implement features that are
+                  <!-- CF: Removed the first sentence/paragraph because it's redundant.

Contributor

juleskremer Feb 20, 2017

lgtm

public/docs/ts/latest/glossary.jade Outdated

                     [promises](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Promise), and
                     [XHR](https://developer.mozilla.org/en-US/docs/Web/API/XMLHttpRequest)
+                    <!-- CF: This link goes to a mozilla page titled "XMLHttpRequest". XHR is mentioned only twice, starting

Contributor

juleskremer Feb 20, 2017

yes

public/docs/ts/latest/guide/forms.jade Outdated

-                If we ignore the `pristine` state, we would hide the message only when the value is valid.
-                If we arrive in this component with a new (blank) hero or an invalid hero,
-                we'll see the error message immediately, before we've done anything.
+                <!-- CF: How about "developers" or "users" (not sure which is appropriate) instead of "folks"? -->

Contributor

juleskremer Feb 20, 2017

developers

public/docs/ts/latest/guide/forms.jade Outdated


		Some folks find that behavior disconcerting.
		<!-- CF: How about "developers" or "users" (not sure which is appropriate) instead of "folks"? -->

Contributor

juleskremer Feb 20, 2017

developers


          Updated with Jules's feedback and fixed a few issues that I didn't ca…

9f1bb2b

…tch the first time.

Contributor Author

cfranger commented Feb 23, 2017

@juleskremer thanks for your feedback. I've updated the "Forms" and "Glossary" pages with your feedback. I also fixed a few issues that I missed on my first pass.


          Merge branch 'master' into cf-edits

90c4f73

googlebot commented Mar 1, 2017

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that they're okay with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.

1 similar comment

googlebot commented Mar 1, 2017

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that they're okay with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.

googlebot added CLA: no and removed CLA: yes labels


          Merge branch 'master' into cf-edits

ef3f394

juleskremer merged commit 0149786 into angular:master

juleskremer added a commit that referenced this pull request


          Revert "docs(Guide): Content edits in the Angular 2 Guide. (#3159)"

b97fa49

This reverts commit 0149786.

this breaks harp compilation

juleskremer added a commit that referenced this pull request


          Revert "Revert "docs(Guide): Content edits in the Angular 2 Guide. (#…

30cc9cf

…3159)""

This reverts commit b97fa49.

We are trying to revert his via github UI and reopen the original PR

juleskremer mentioned this pull request

Revert "Content edits in the Angular 2 Guide." #3328

Merged

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels