Skip to content
This repository was archived by the owner on Dec 4, 2017. It is now read-only.

chore: convert relative templateUrl/styleUrls to have ./ #3071

Merged
merged 2 commits into from
Jan 4, 2017

Conversation

filipesilva
Copy link
Contributor

@filipesilva filipesilva commented Jan 4, 2017

/cc @Foxandxss @wardbell

See my comment below about piggy-backing with improvements to Style Guide.

@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that they're okay with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.

1 similar comment
@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that they're okay with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.

@googlebot googlebot added CLA: no and removed CLA: yes labels Jan 4, 2017
@wardbell
Copy link
Contributor

wardbell commented Jan 4, 2017

Thank you!

I dug into Style Guide which was hiding the moduleId=module.id in many examples for some reason ... and thus sending the wrong message!

Fixed that. Started adding/correcting advice, and soon had a lot of Style Guide "improvements".

I'll merge these with yours ... they overlap so much ... but keep the commits separate.

@wardbell wardbell merged commit 0d5877d into angular:master Jan 4, 2017
@wardbell wardbell deleted the relative-paths branch January 4, 2017 23:58
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants