This repository was archived by the owner on Dec 4, 2017. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 877
docs(structural-directives): typos and clean-up #3031
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wardbell
suggested changes
Jan 3, 2017
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like all but two of your changes. Please revert those and I'll be happy to unblock and merge.
@@ -209,7 +209,7 @@ figure.image-display | |||
|
|||
+makeExample('structural-directives/ts/app/structural-directives.component.html', 'ngFor-template')(format=".") | |||
:marked | |||
The basic pattern is the same: create a `<template>`, relocate the content, | |||
The basic pattern is the same: create a `<template>`, relocate the content, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please revert to the
. I wanted that extra spacing.
manipulates the DOM and how we can do it ourselves in our own directives. | ||
|
||
In this chapter we will | ||
- [learn what structural directives are](#definition) | ||
- [study *ngIf*](#ngIf) | ||
- [discover the <template> element](#template) | ||
- [discover the <template> element](#template) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please revert the <
as our jade engine is confused by angle brackets.
Reverting some of the changes as requested
Makes sense. Reverted 👍 |
wardbell
approved these changes
Jan 3, 2017
Thanks! |
abdel-ships-it
pushed a commit
to abdel-ships-it/angular.io
that referenced
this pull request
Feb 11, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.