Skip to content
This repository was archived by the owner on Dec 4, 2017. It is now read-only.

docs(structural-directives): typos and clean-up #3031

Merged
merged 2 commits into from
Jan 3, 2017

Conversation

jsayol
Copy link
Contributor

@jsayol jsayol commented Dec 23, 2016

No description provided.

Copy link
Contributor

@wardbell wardbell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like all but two of your changes. Please revert those and I'll be happy to unblock and merge.

@@ -209,7 +209,7 @@ figure.image-display

+makeExample('structural-directives/ts/app/structural-directives.component.html', 'ngFor-template')(format=".")
:marked
The basic pattern is the same:&nbsp; create a `<template>`, relocate the content,
The basic pattern is the same: create a `<template>`, relocate the content,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please revert to the &nbsp;. I wanted that extra spacing.

manipulates the DOM and how we can do it ourselves in our own directives.

In this chapter we will
- [learn what structural directives are](#definition)
- [study *ngIf*](#ngIf)
- [discover the &lt;template> element](#template)
- [discover the <template> element](#template)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please revert the &lt; as our jade engine is confused by angle brackets.

Reverting some of the changes as requested
@jsayol
Copy link
Contributor Author

jsayol commented Jan 3, 2017

Makes sense. Reverted 👍

@wardbell wardbell merged commit 2f28b32 into angular:master Jan 3, 2017
@wardbell
Copy link
Contributor

wardbell commented Jan 3, 2017

Thanks!

abdel-ships-it pushed a commit to abdel-ships-it/angular.io that referenced this pull request Feb 11, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants