This repository was archived by the owner on Dec 4, 2017. It is now read-only.
docs(pipes/dart): improve FetchJsonPipe discussion #2937
Merged
+50
−39
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
35 tasks
Followup to angular#2923 ``` Suites passed: public/docs/_examples/pipes/dart ```
chalin
force-pushed
the
chalin-dart-sync-pipes-1206
branch
from
2e569c2 to
8625504
Compare
kwalrath
approved these changes
Dec 7, 2016
| @@ -361,7 +369,7 @@ h3#async-pipe The impure #[i AsyncPipe] | |||
| The component doesn't have to subscribe to the async data source, | |||
| it doesn't extract the resolved values and expose them for binding, | |||
| and the component doesn't have to unsubscribe when it is destroyed | |||
| (a potential source of memory leaks). | |||
| (a potent source of memory leaks). | |||
There was a problem hiding this comment.
This change (potential -> potent) seems questionable, but since it's not yours, Patrice...
@kapunahelewong maybe you can fix it?
There was a problem hiding this comment.
Yes, I found that a bit strange too, but decided to go along with @wardbell on that one (focusing instead on the heart of the changes at hand).
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup to #2923
cc @wardbell - as usual, this is mainly updates to Dart files but with minor tweaks to the TS Jade. There was actually a
:markedmissing so some text wasn't showing up. I've fixed that.