Skip to content
This repository was archived by the owner on Dec 4, 2017. It is now read-only.

docs(forms): revise prose for form.reset #2853

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 15 additions & 19 deletions public/docs/_examples/forms/ts/app/hero-form.component.html
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ <h1>Hero Form</h1>
required
[(ngModel)]="model.power" name="power"
#power="ngModel" >
<option *ngFor="let p of powers" [value]="p">{{p}}</option>
<option *ngFor="let pow of powers" [value]="pow">{{pow}}</option>
</select>
<div [hidden]="power.valid || power.pristine" class="alert alert-danger">
Power is required
Expand All @@ -46,12 +46,18 @@ <h1>Hero Form</h1>
<!-- #docregion submit-button -->
<button type="submit" class="btn btn-default" [disabled]="!heroForm.form.valid">Submit</button>
<!-- #enddocregion submit-button -->

<!-- #docregion new-hero-button -->
<!-- #docregion new-hero-button-form-reset -->
<button type="button" class="btn btn-default" (click)="newHero(); heroForm.reset()">New Hero</button>
<!-- #enddocregion new-hero-button -->

<!-- #enddocregion new-hero-button-form-reset -->
<!-- #enddocregion final -->
<i>with</i> reset

&nbsp;&nbsp;
<!-- #docregion new-hero-button-no-reset -->
<button type="button" class="btn btn-default" (click)="newHero()">New Hero</button>
<!-- #enddocregion new-hero-button-no-reset -->
<i>without</i> reset

<!-- NOT SHOWN IN DOCS -->
<div>
<hr>
Expand Down Expand Up @@ -126,7 +132,7 @@ <h1>Hero Form</h1>
<div class="form-group">
<label for="power">Hero Power</label>
<select class="form-control" id="power" required>
<option *ngFor="let p of powers" [value]="p">{{p}}</option>
<option *ngFor="let pow of powers" [value]="pow">{{pow}}</option>
</select>
</div>

Expand Down Expand Up @@ -165,7 +171,7 @@ <h1>Hero Form</h1>
<select class="form-control" id="power"
required
[(ngModel)]="model.power" name="power">
<option *ngFor="let p of powers" [value]="p">{{p}}</option>
<option *ngFor="let pow of powers" [value]="pow">{{pow}}</option>
</select>
</div>

Expand All @@ -178,12 +184,12 @@ <h1>Hero Form</h1>

<!-- EXTRA MATERIAL FOR DOCUMENTATION -->
<hr>
<!-- #docregion ngModel-1-->
<!-- #docregion ngModelName-1 -->
<input type="text" class="form-control" id="name"
required
[(ngModel)]="model.name" name="name">
TODO: remove this: {{model.name}}
<!-- #enddocregion ngModel-1-->
<!-- #enddocregion ngModelName-1 -->
<hr>
<!-- #docregion ngModel-3-->
<input type="text" class="form-control" id="name"
Expand All @@ -193,16 +199,6 @@ <h1>Hero Form</h1>
TODO: remove this: {{model.name}}
<!-- #enddocregion ngModel-3-->
<hr>
<!-- #docregion form-reset -->
<button type="button" class="btn btn-default" (click)="newHero(); heroForm.reset()">New Hero</button>
<!-- #enddocregion form-reset -->

<!-- #docregion ngModelName-1 -->
<input type="text" class="form-control" id="name"
required
[(ngModel)]="model.name" name="name" >
<!-- #enddocregion ngModelName-1 -->
<hr>
<!-- #docregion ngModelName-2 -->
<input type="text" class="form-control" id="name"
required
Expand Down
2 changes: 0 additions & 2 deletions public/docs/_examples/forms/ts/app/hero-form.component.ts
Original file line number Diff line number Diff line change
Expand Up @@ -30,11 +30,9 @@ export class HeroFormComponent {

// #docregion final
// #docregion new-hero
// #docregion new-hero-v1
newHero() {
this.model = new Hero(42, '', '');
}
// #enddocregion new-hero-v1
// #enddocregion new-hero
// #enddocregion final
//////// NOT SHOWN IN DOCS ////////
Expand Down
3 changes: 0 additions & 3 deletions public/docs/_examples/forms/ts/app/main.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,4 @@
import { platformBrowserDynamic } from '@angular/platform-browser-dynamic';
import { AppModule } from './app.module';

// Compiles the module (asynchronously) with the runtime compiler
// which generates a compiled module factory in memory.
// Then bootstraps with that factory, targeting the browser.
platformBrowserDynamic().bootstrapModule(AppModule);
Loading