Skip to content
This repository was archived by the owner on Dec 4, 2017. It is now read-only.

examples(toh-5, toh-6): fix Dart e2e #2846

Merged

Conversation

chalin
Copy link
Contributor

@chalin chalin commented Nov 21, 2016

In the dashboard, the:

  • route name was changed to 'HeroDetail' but either of '/HeroDetail' or '../HeroDetail' would have worked
  • route parameter expression needed a call to toString()

E2e tests are now passing:

Suites passed:
  public/docs/_examples/toh-5/dart
  public/docs/_examples/toh-6/dart

@chalin chalin added the dart label Nov 21, 2016
@Foxandxss Foxandxss merged commit ad3fbad into angular:master Nov 21, 2016
@Foxandxss Foxandxss deleted the chalin-dart-toh-5-and-6-e2e-1121 branch November 21, 2016 12:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants