Skip to content
This repository was archived by the owner on Dec 4, 2017. It is now read-only.

Update router.jade: Fix missing anchor id #2817

Merged
merged 1 commit into from
Nov 17, 2016
Merged

Update router.jade: Fix missing anchor id #2817

merged 1 commit into from
Nov 17, 2016

Conversation

johnjacobkenny
Copy link
Contributor

The link Importing from the router library (https://angular.io/docs/ts/latest/guide/router.html#import) does not work.

I supposed that this was the corresponding section to be linked to.

@johnjacobkenny
Update router.jade: Fix missing anchor id
7368bbd 
The link *Importing from the router library* (https://angular.io/docs/ts/latest/guide/router.html#import) does not work.

I supposed that this was the corresponding section to be linked to.
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.

  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

1 similar comment
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.

  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@johnjacobkenny
Copy link
Contributor Author

johnjacobkenny commented Nov 17, 2016 •
edited
Loading

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

1 similar comment
@googlebot
Copy link

CLAs look good, thanks!

@Foxandxss Foxandxss merged commit 7febba6 into angular:master Nov 17, 2016
@johnjacobkenny johnjacobkenny deleted the patch-1 branch November 18, 2016 01:49
filipesilva added a commit to IdeaBlade/angular.io that referenced this pull request Nov 18, 2016
@filipesilva
Squashed commit of the following:
dcf96d1 
commit 7c8938a
Author: Patrice Chalin <[email protected]>
Date:   Fri Nov 18 07:53:41 2016 -0800

    example(pipes): Dart e2e fix (angular#2825)

    Match TS example and only bootstrap AppComponent.

commit 1c2d14a
Author: Patrice Chalin <[email protected]>
Date:   Thu Nov 17 16:53:28 2016 -0800

    docs(guide & api): feedback/issue links for Dart should refer to Dart repos (angular#2821)

    * docs(guide/index): feedback link to Dart repo for Dart

    - Also added links to chapters mentioned in table.
    - Other minor copyedits.

    * docs(api): issue links should refer to Dart repo

    * post-review updates

    * add link to Advance and Guide chapters

    * ensure that we can determine which language is active

commit e59cd9a
Author: Eric Jimenez <[email protected]>
Date:   Thu Nov 17 18:02:32 2016 -0500

    chore: remove deprecated `clear=` and use clear layout helpers (angular#2822)

    * define clear layout helpers

    * replace deprecated clear= with helper

commit bde8fe1
Author: Eric Jimenez <[email protected]>
Date:   Thu Nov 17 17:54:42 2016 -0500

    remove grid fluid from dart api list (angular#2823)

commit f993315
Author: Patrice Chalin <[email protected]>
Date:   Thu Nov 17 14:10:28 2016 -0800

    chore(dart): complete the renaming of "Angular 2" to "Angular" (angular#2820)

    Contributes to angular#2407

    - Dropped the “2” in “Angular 2” and “angular2_*” where appropriate.
    - Did a partial sync of `_cache/guide/pipes.jade`
    - In quickstart, changed `Try changing the message to "Hello Angular
    2!”` to `Try changing the message to "Hello Again Angular!”`.

commit d853a29
Author: Patrice Chalin <[email protected]>
Date:   Thu Nov 17 13:47:51 2016 -0800

    examples(dart): demote some packages to dev_dependencies (angular#2818)

    Fixes angular#2777

commit 7febba6
Author: Kenny John Jacob <[email protected]>
Date:   Fri Nov 18 02:24:55 2016 +0530

    docs(router): fix missing anchor id (angular#2817)

    The link *Importing from the router library* (https://angular.io/docs/ts/latest/guide/router.html#import) does not work.

    I supposed that this was the corresponding section to be linked to.

commit 2a3dbe5
Author: Eric Jimenez <[email protected]>
Date:   Thu Nov 17 12:37:14 2016 -0500

    replace clearfix with a wrapping flexbox (angular#2819)

commit 061e50f
Author: Patrice Chalin <[email protected]>
Date:   Wed Nov 16 10:02:31 2016 -0800

    docs: adjust page heading levels (angular#2813)

    * docs: adjust page heading levels

    Only the page TOC should be at heading level 1. All other headings
    should start at level 2. This commit also removes duplicate headings,
    in continuation of angular#2796.

    (This fix is necessary to support an auto-TOC feature.)

commit 31e0101
Author: Filipe Silva <[email protected]>
Date:   Wed Nov 16 17:51:06 2016 +0000

    fix(live-example): correctly match example name (angular#2815)

    Currently, when visiting a page with a relative link e.g. https://angular.io/docs/ts/latest/guide/testing.html#!#top, `NgIoUtil.getExampleName` fails to match the example name.

    This results on `live-example` directives on that page missing the example name in the link: instead of linking to https://angular.io/resources/live-examples/testing/ts/plnkr.html it will link to https://angular.io/resources/live-examples//ts/plnkr.html (notice the missing `testing` and the double slashes).

commit e0aecb3
Author: Patrice Chalin <[email protected]>
Date:   Tue Nov 15 15:38:02 2016 -0800

    docs(struct-directives): update Dart cache (angular#2806)

    Only minor prose edits in this PR. No net change in the generated HTML
    for the TS side.

commit 0dfda08
Author: Patrice Chalin <[email protected]>
Date:   Tue Nov 15 15:36:34 2016 -0800

    docs: in links use href=foo#bar not foo#!#bar (angular#2807)

commit 64bce18
Author: Patrice Chalin <[email protected]>
Date:   Tue Nov 15 14:58:56 2016 -0800

    e2e(dependency-injection): fix for Dart and simplification for TS

    Fixes angular#2493

    No need to dual boot `AppComponent` and `ProvidersComponent` only to
    ensure that we could demo optional injection; instead just inject null
    for the `@Optional` constructor parameter type.

    No prose is affected by these changes.

commit 4a4144e
Author: Patrice Chalin <[email protected]>
Date:   Tue Nov 15 14:55:33 2016 -0800

    docs(tutorial): update Dart cache for toh intro (angular#2805)

commit f70ba97
Author: Patrice Chalin <[email protected]>
Date:   Tue Nov 15 08:39:03 2016 -0800

    example(architecture/dart): drop currency pipe workaround (angular#2804)

    Fixes angular#1898
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Foxandxss Foxandxss Foxandxss approved these changes

Assignees
No one assigned
Labels
CLA: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@johnjacobkenny @googlebot @Foxandxss