This repository was archived by the owner on Dec 4, 2017. It is now read-only.
docs(upgrade): update NgUpgrade with AoT, router, unit tests #2803
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
filipesilva
changed the title
filipesilva
force-pushed
the
ngupgrade-followup
branch
2 times, most recently
from
30e574c to
e86a2b8
Compare
filipesilva
changed the title
filipesilva
changed the title
filipesilva
force-pushed
the
ngupgrade-followup
branch
from
dcf96d1 to
ebb4297
Compare
filipesilva
added a commit
to angular/quickstart
that referenced
this pull request
Nov 24, 2016
The package is not listed in `package.json` and angular/angular.io#2803 will contain instructions to add it manually.
filipesilva
force-pushed
the
ngupgrade-followup
branch
from
15f413c to
b819218
Compare
filipesilva
changed the title
Foxandxss
reviewed
Nov 28, 2016
| ], | ||
| providers: [ | ||
| // use hash location strategy | ||
| { provide: LocationStrategy, useClass: HashLocationStrategy }, |
There was a problem hiding this comment.
Is this needed for upgrade? IIRC the router module had a parameter to include this strategy or not.
wardbell
force-pushed
the
ngupgrade-followup
branch
from
c810a10 to
86fe8db
Compare
3 tasks
|
This PR needs to be rebased. Other than that, is anything blocking it? All tasks from the first post are marked as completed. |
filipesilva
force-pushed
the
ngupgrade-followup
branch
from
86fe8db to
c3c7a71
Compare
Urigo
added a commit
to Urigo/angular.io
that referenced
this pull request
Feb 16, 2017
Urigo
added a commit
to Urigo/angular.io
that referenced
this pull request
Feb 19, 2017
Urigo
added a commit
to Urigo/angular.io
that referenced
this pull request
Feb 20, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup from #2781
Update unit tests and prose