This repository was archived by the owner on Dec 4, 2017. It is now read-only.
chore: fix broken links and transform API links for dart docs #2761
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Dart non-api doc pages w/ links to API entries will now have those links translated from a TS API reference URL to a Dart API reference URL. - Created and ran a link checker to verify that all such links to API entries refer to Dart. - Fixed links to pages that have moved: - JS & Dart: `i18n` is under now `cookbook` not `guide` - Dart: testing page is now directly under guide. Contributes to angular#1895 Fixes angular#2273
|
Staged at https://kw-angular-io.firebaseapp.com/dart. Some notes from poking around:
I ran the script, and it seemed to work although it didn't catch the bad API link in dependency-injection.html. Anyway, this is an improvement and doesn't break anything. LGTM. |
|
@kwalrath - thanks for the detailed feedback. I'll be addressing each of the issues you mentioned and follow-up here. |
3 tasks
|
Follow-up issue is #2772. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
i18nis under nowcookbooknotguideContributes to #1895
Fixes #2273