This repository was archived by the owner on Dec 4, 2017. It is now read-only.
chore: add firebase project name to prompt #2743
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chalin
changed the title
chalin
changed the title
Remove project name from firebase.json, since that is deprecated. The `check-deploy` gulp task now checks that an active project is defined at the start of `check-deploy`. To set the active project use: `firebase use <project-or-alias-name>`. Fixes angular#2576
chalin
force-pushed
the
chalin-adjust-deploy-prompt-1102
branch
from
f673338 to
567ebac
Compare
chalin
changed the title
|
Best reviewed by ignoring whitespace. |
kwalrath
reviewed
Nov 3, 2016
| prompt.start(); | ||
| var schema = { | ||
| name: 'shouldDeploy', | ||
| description: 'Deploy to Firebase? (y/n)', | ||
| description: `Deploy ${WWW} to firebase? (y/n)`, |
There was a problem hiding this comment.
back ticks are really valid here?
There was a problem hiding this comment.
Yes, its TS syntax for a string with interpolation (i.e., the ${WWW} inside the string).
| } catch (e) { | ||
| // Rerun command so user gets project + alias info | ||
| execSync('firebase use', {stdio:[0,1,2]}); | ||
| throw `\nAborting: no firebase project selected. Run:\n\n firebase use <project-or-alias-name>\n\n`; |
There was a problem hiding this comment.
Perhaps a little help on how to get the project-or-alias-name? Or an example of a name?
There was a problem hiding this comment.
That's what line 773 does. It generates output like:
No project is currently active.
Project aliases for /Users/chalin/git/angular.io:
live (angular-io)
ngdocsdev (ngdocsdev)
kw-dev (kw-angular-io)
dev (angular-io-dev)
Is that good enough?
|
LGTM. Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove project name from
firebase.json, since that is deprecated.The
check-deploygulp task now checks that an active project is defined at the start ofcheck-deploy.To set the active project use:
firebase use <project-or-alias-name>.Fixes #2576
cc @kwalrath