Skip to content
This repository was archived by the owner on Dec 4, 2017. It is now read-only.

[WIP] docs(user-input): Jessica's user input edits #2683

Merged
merged 6 commits into from
Nov 21, 2016

Conversation

kapunahelewong
Copy link
Contributor

Original PR had some issues. Testing to see if a local rebase resolved. Original branch is user-input-edits. This one, Jessica-user-input-edits, is a copy of the original with a rebase.

@kapunahelewong
Copy link
Contributor Author

@jessica-unifi Can you look this over and make sure it's what you intended?

@chalin
Copy link
Contributor

chalin commented Oct 26, 2016

Supersedes #2397; Kapunahele successfully rebased it.

cc @naomiblack @wardbell

@kapunahelewong kapunahelewong force-pushed the Jessica-user-input-edits branch 2 times, most recently from a8bda28 to 1995fce Compare October 26, 2016 21:34
@kapunahelewong kapunahelewong force-pushed the Jessica-user-input-edits branch from f4a51fc to 7d142c1 Compare October 27, 2016 14:26
@wardbell wardbell changed the title [WIP] Jessica's user input edits [WIP] docs(user-input): Jessica's user input edits Nov 14, 2016
@wardbell wardbell force-pushed the Jessica-user-input-edits branch from 4672701 to 16ee234 Compare November 21, 2016 19:49
@wardbell
Copy link
Contributor

I've had to fix a few things that were either wrong in the original or got lost in translation. For example, the first code snippet extracts the entire value of the input box from the $event, not the individual keystrokes!
Eliminated the pointless examples of the wrong way to use the template reference variable

@wardbell wardbell merged commit 694b58d into angular:master Nov 21, 2016
@wardbell wardbell deleted the Jessica-user-input-edits branch November 21, 2016 20:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants