docs(router): Updated routing examples to use routing module #2478
Conversation
brandonroberts
force-pushed
the
routing-modules
branch
5 times, most recently
from
aa17db4 to
3f30c91
Compare
brandonroberts
changed the title
| @@ -2,7 +2,7 @@ | |||
|
|
|||
| block includes | |||
| include ../_util-fns | |||
| - var _appRoutingTsVsAppComp = 'app.routing.ts' | |||
| - var _appRoutingTsVsAppComp = 'app.module.ts' | |||
There was a problem hiding this comment.
what does this jade syntax do? If its code, we dont use underscore prefixes by convention. If its styling, ignore this :)
There was a problem hiding this comment.
Local Jade variable names used to render TS and Dart prose from the same source. Such variable names do not appear in the rendered HTML.
| @@ -229,7 +229,7 @@ block get-heroes-details | |||
| ## Update hero details | |||
|
|
|||
| We can edit a hero's name already in the hero detail view. Go ahead and try | |||
| it. As we type, the hero name is updated in the view heading. | |||
| it. As we type, the hero name is updated in the view heading. | |||
There was a problem hiding this comment.
@wardbell mentioned to me a few days ago that we are switching from the "we" to the "you" in our prose. If so, this needs to switch. But check with Ward.
There was a problem hiding this comment.
We are switching ot you. But this switch is just one part of a deliberate sweep of the docs leading to conformance with the Google docs standards. No need for Brandon to take that on for this particular revision.
After a doc has been converted, then our revisions must conform.
brandonroberts
force-pushed
the
routing-modules
branch
from
3f30c91 to
1c69566
Compare
brandonroberts
force-pushed
the
routing-modules
branch
from
1c69566 to
3792476
Compare
|
This PR responds to the concern in issue #2527 by deleting the offending section |
Simplified routing in tutorial example Updated ngmodule guide and ngmodule faq with routing module prose
wardbell
force-pushed
the
routing-modules
branch
from
3792476 to
c1bc74f
Compare
All examples updating to use separate "routing modules"
Routing tutorial simplified and prose updated
Router developer guide examples and prose updated