Kwong glossary updates #2292
Kwong glossary updates #2292
Conversation
| By compiling your application using the compiler-cli, `ngc`, you can bootstrap directly | ||
| to a Module Factory, meaning you don't need to include the Angular compiler in your javascript bundle. | ||
| to a Module Factory, meaning you don't need to include the Angular compiler in your Javascript bundle. |
There was a problem hiding this comment.
Global: Javascript -> JavaScript
There was a problem hiding this comment.
Done. This was the only one that got through. :)
|
The changes you've made look good, but there are many more changes you could make—especially ones that came up in reviews of previous pages you worked on. I marked a few things, but I wasn't too thorough this time. If you could refer to the checklist (and, better yet, improve the checklist) each time you edit a doc, I think that'd improve the quality of the docs. |
kapunahelewong
force-pushed
the
kwong-glossary-updates
branch
from
33bea56 to
c078a59
Compare
| @@ -28,26 +28,25 @@ block includes | |||
| +ifDocsFor('ts') | |||
| a#aot | |||
| :marked | |||
| ## Ahead of Time (AOT) Compilation | |||
| ## Ahead of Time (AOT) compilation | |||
There was a problem hiding this comment.
In fact, let's make this "Ahead-of-time", since it's a adjectival phrase before a noun. (http://www.grammarbook.com/punctuation/hyphens.asp)
There was a problem hiding this comment.
Done. (And bookmarked that page - thanks!)
|
Looks great! I found a few more capitalization/hyphenation things, but once you fix those, LGTM. |
kapunahelewong
force-pushed
the
kwong-glossary-updates
branch
3 times, most recently
from
d487821 to
eb9eb10
Compare
|
LGTM once you resolve the conflicts. |
kapunahelewong
force-pushed
the
kwong-glossary-updates
branch
5 times, most recently
from
b5b44d6 to
cc886f6
Compare
|
Having issues resolving conflicts. Testing starting over in a new PR. I have copied the contents of glossary.jade as they are in this repo currently and am pushing up in #2346 |
Edits to Glossary in docs/ts/latest/glossary.jade.