Skip to content
This repository was archived by the owner on Dec 4, 2017. It is now read-only.

Fixed Url of "Should I add providers to the root AppModule or the root AppComponent?" #2251

Closed
wants to merge 1 commit into from

Conversation

pdelorme
Copy link
Contributor

@pdelorme pdelorme commented Sep 2, 2016

Fixed url "Should I add providers to the root AppModule or the root AppComponent?" to proper link : NgModule to NgModule-FAQ

…t AppComponent?"

Fixed url "Should I add providers to the root AppModule or the root AppComponent?" to proper link : NgModule to NgModule-FAQ
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

1 similar comment
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@pdelorme
Copy link
Contributor Author

pdelorme commented Sep 2, 2016

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

1 similar comment
@googlebot
Copy link

CLAs look good, thanks!

@googlebot googlebot added CLA: yes and removed CLA: no labels Sep 2, 2016
@wardbell wardbell closed this in 1e0bd22 Sep 3, 2016
@wardbell
Copy link
Contributor

wardbell commented Sep 3, 2016

Thanks! Merged with slight change.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants