Skip to content
This repository was archived by the owner on Dec 4, 2017. It is now read-only.

api-builder: replace underscores from jade filenames #2212

Closed
wants to merge 2 commits into from

Conversation

petebacondarwin
Copy link
Contributor

Closes #2184

@chalin
Copy link
Contributor

chalin commented Aug 27, 2016

Ah, nice and simple fix. Maybe it would be better, though, to replace only the first leading underscore with a minus? Although unlikely, this could avoid potential clashes between an entry for __foo and _foo.

LGTM (though I haven't tried it).

@chalin
Copy link
Contributor

chalin commented Aug 27, 2016

cc @Foxandxss

@petebacondarwin
Copy link
Contributor Author

I fixed it up to replace each leading '_' with the same number of leading '-'

@wardbell
Copy link
Contributor

Please follow up with the Angular team. They should not be exporting public API members with leading underscore. Therefore, this appears to be a solution looking for a non-existent problem.

@petebacondarwin
Copy link
Contributor Author

Although it is an "experimental" export so perhaps they wanted it to look a "bit private".

@petebacondarwin
Copy link
Contributor Author

I think we should probably close this one now (@chalin?) given that @IgorMinar closed the original issue.

@chalin
Copy link
Contributor

chalin commented Oct 7, 2016

Yes, that's fine.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants