This repository was archived by the owner on Dec 4, 2017. It is now read-only.
chore(site): support site build w/o recompiling API docs #2202
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@wardbell @Foxandxss @kwalrath : ready for review. |
|
I like the idea. Will try it! |
|
We used (or use) to have 20 tasks doing similar jobs, if we can reduce a bunch of them, I will be all in. We have 3-4 that harpCompile, another that serves, another that compiles and serves... |
|
So much faster! There's one issue with the output, though: The "Deploy to Firebase? (y/n):" question is obscured by the 3 new lines of "Rename" output. Could you move those lines to be before the deploy prompt? Here's what I see: |
chalin
force-pushed
the
chalin-chore-build-wo-api-0826
branch
2 times, most recently
from
3bfa5f7 to
987dea5
Compare
If the site has already been built once, then rebuild the site without re-harp-compiling the API docs use: `gulp check-deploy —lang=‘’` Otherwise specify the languages whose API docs are to be rebuilt; as usual, omitting the `—lang` flag is equivalent to `—lang=all` which is equivalent to `—lang=‘ts|js|dart’`. Other changes to gulp tasks: - Renamed `serve` to `harp-serve`. - Removed `check-serve`. Use `harp-compile` followed by `serve-www’ instead. - `harp-compile` now also defaults to `—lang=all`.
- Ensure that the deploy prompt can be seen.
chalin
force-pushed
the
chalin-chore-build-wo-api-0826
branch
from
987dea5 to
e843491
Compare
|
The newest version works great for me! OK if I merge this, @wardbell & @Foxandxss? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the site has already been built once, then rebuild the site without re-harp-compiling the API docs use:
Otherwise specify the languages whose API docs are to be rebuilt; as usual, omitting the
--langflag is equivalent to--lang=allwhich is equivalent to--lang=‘ts|js|dart’.Other changes to gulp tasks:
servetoharp-serve.check-serve. Useharp-compilefollowed by `serve-www’ instead.harp-compilenow also defaults to--lang=all.Fixes #2022.