Skip to content
This repository was archived by the owner on Dec 4, 2017. It is now read-only.

chore: update to rc6 #2177

Merged
merged 1 commit into from
Sep 1, 2016
Merged

chore: update to rc6 #2177

merged 1 commit into from
Sep 1, 2016

Conversation

filipesilva
Copy link
Contributor

@filipesilva filipesilva commented Aug 22, 2016

The suites still failing on CI are due to a Type from @angular/core now being a generic (Type<T>), and thus triggering a compilation failure on https://github.com/angular/in-memory-web-api. Here is a PR that addresses that: angular/in-memory-web-api#18.

This is still missing package.json RC6 versions.

@filipesilva filipesilva changed the title chore: update to rc6 [WIP] chore: update to rc6 Aug 22, 2016
@wardbell
Copy link
Contributor

We'll fix the in-memory-web-api at the same time that we process this. Just have to figure out the timing.

@filipesilva filipesilva force-pushed the rc6 branch 6 times, most recently from e655f31 to c23995c Compare August 25, 2016 23:14
@filipesilva
Copy link
Contributor Author

filipesilva commented Aug 26, 2016

Breaking changes, not previously deprecated

  • Type -> Type<T>
  • ExceptionHandler -> ErrorHandler,
  • SanitizationService -> Sanitizer,
  • DomSanitizationService -> DomSanitizer
  • BaseException has been removed. Use JS new Error(...)

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request) and all commit authors, but as best as we can tell these commits were authored by someone else. If that's the case, please add them to this pull request and have them confirm that they're okay with these commits being contributed to Google. If we're mistaken and you did author these commits, just reply here to confirm.

1 similar comment
@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request) and all commit authors, but as best as we can tell these commits were authored by someone else. If that's the case, please add them to this pull request and have them confirm that they're okay with these commits being contributed to Google. If we're mistaken and you did author these commits, just reply here to confirm.

@googlebot
Copy link

CLAs look good, thanks!

1 similar comment
@googlebot
Copy link

CLAs look good, thanks!

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request) and all commit authors, but as best as we can tell these commits were authored by someone else. If that's the case, please add them to this pull request and have them confirm that they're okay with these commits being contributed to Google. If we're mistaken and you did author these commits, just reply here to confirm.

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request) and all commit authors, but as best as we can tell these commits were authored by someone else. If that's the case, please add them to this pull request and have them confirm that they're okay with these commits being contributed to Google. If we're mistaken and you did author these commits, just reply here to confirm.

@Foxandxss
Copy link
Member

We are fine bot.

@googlebot
Copy link

CLAs look good, thanks!

@googlebot
Copy link

CLAs look good, thanks!

@Foxandxss Foxandxss changed the title [WIP] chore: update to rc6 chore: update to rc6 Sep 1, 2016
@wardbell wardbell merged commit 0c96271 into angular:master Sep 1, 2016
@wardbell wardbell deleted the rc6 branch September 1, 2016 01:08
chalin added a commit to chalin/angular.io that referenced this pull request Sep 8, 2016
Make equivalent TS code changes to Dart sample.

This sync’s Dart with all angular#2177 changes pertinent to Dart.

E2E tests pass now for Dart, Suites passed:
-  public/docs/_examples/lifecycle-hooks/ts
kwalrath pushed a commit that referenced this pull request Sep 8, 2016
Make equivalent TS code changes to Dart sample.

This sync’s Dart with all #2177 changes pertinent to Dart.

E2E tests pass now for Dart, Suites passed:
-  public/docs/_examples/lifecycle-hooks/ts
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants