Skip to content
This repository was archived by the owner on Dec 4, 2017. It is now read-only.

chore(router): Added ModuleWithProviders to routing exports #2113

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -2,17 +2,16 @@
import { NgModule } from '@angular/core';
import { BrowserModule } from '@angular/platform-browser';
import { FormsModule } from '@angular/forms';
import { RouterModule } from '@angular/router';

import { AppComponent } from './app.component';
import { MovieListComponent } from './movie-list.component';
import { routes } from './app.routes';
import { routing } from './app.routing';

@NgModule({
imports: [
BrowserModule,
FormsModule,
RouterModule.forRoot(routes, {})
routing
],
declarations: [
AppComponent,
Expand Down

This file was deleted.

Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
// #docregion
import { ModuleWithProviders } from '@angular/core';
import { Routes, RouterModule } from '@angular/router';

import { MovieListComponent } from './movie-list.component';

const routes: Routes = [
{ path: '', redirectTo: '/movies', pathMatch: 'full' },
{ path: 'movies', component: MovieListComponent }
];

export const routing: ModuleWithProviders = RouterModule.forRoot(routes);
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,8 @@
import { BrowserModule } from '@angular/platform-browser';
import { FormsModule } from '@angular/forms';
import { XHRBackend } from '@angular/http';
// import { appRouterProviders } from './app.routes';
/* import { routing,
appRoutingProviders } from './app.routing';*/
import { LocationStrategy,
HashLocationStrategy } from '@angular/common';
import { NgModule } from '@angular/core';
Expand Down Expand Up @@ -51,15 +52,19 @@ const C_DIRECTIVES = [

// #docregion bootstrap
@NgModule({
imports: [ BrowserModule, FormsModule ],
imports: [
BrowserModule,
FormsModule,
// routing TODO: add routes
],
declarations: [ ...DIRECTIVES,
...B_DIRECTIVES,
...C_DIRECTIVES,
AliceComponent,
AlexComponent ],
bootstrap: [ AppComponent ],
providers: [
// appRouterProviders, TODO: add routes
// appRoutingProviders, TODO: add routes
{ provide: LocationStrategy, useClass: HashLocationStrategy },

{ provide: XHRBackend, useClass: InMemoryBackendService }, // in-mem server
Expand All @@ -71,4 +76,3 @@ export class AppModule {
}
}
// #enddocregion bootstraps

This file was deleted.

Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
import { ModuleWithProviders } from '@angular/core';
import { Routes, RouterModule } from '@angular/router';

const routes: Routes = [];

export const routing: ModuleWithProviders = RouterModule.forRoot(routes);

export const appRoutingProviders: any[] = [

];
3 changes: 2 additions & 1 deletion public/docs/_examples/ngmodule/ts/app/app.routing.3.ts
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
import { ModuleWithProviders } from '@angular/core';
import { Routes,
RouterModule } from '@angular/router';

Expand All @@ -7,4 +8,4 @@ export const routes: Routes = [
{ path: 'heroes', loadChildren: 'app/hero/hero.module.3' }
];

export const routing = RouterModule.forRoot(routes);
export const routing: ModuleWithProviders = RouterModule.forRoot(routes);
3 changes: 2 additions & 1 deletion public/docs/_examples/ngmodule/ts/app/app.routing.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
// #docregion
import { ModuleWithProviders } from '@angular/core';
import { Routes,
RouterModule } from '@angular/router';

Expand All @@ -11,5 +12,5 @@ export const routes: Routes = [
];

// #docregion forRoot
export const routing = RouterModule.forRoot(routes);
export const routing: ModuleWithProviders = RouterModule.forRoot(routes);
// #enddocregion forRoot
Original file line number Diff line number Diff line change
@@ -1,7 +1,8 @@
import { ModuleWithProviders } from '@angular/core';
import { RouterModule } from '@angular/router';

import { ContactComponent } from './contact.component.3';

export const routing = RouterModule.forChild([
export const routing: ModuleWithProviders = RouterModule.forChild([
{ path: 'contact', component: ContactComponent}
]);
Original file line number Diff line number Diff line change
@@ -1,9 +1,10 @@
import { ModuleWithProviders } from '@angular/core';
import { RouterModule } from '@angular/router';

import { ContactComponent } from './contact.component';

// #docregion routing
export const routing = RouterModule.forChild([
export const routing: ModuleWithProviders = RouterModule.forChild([
{ path: 'contact', component: ContactComponent}
]);
// #enddocregion
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
import { ModuleWithProviders } from '@angular/core';
import { Routes,
RouterModule } from '@angular/router';

Expand All @@ -10,4 +11,4 @@ const routes: Routes = [
{ path: ':id', component: CrisisDetailComponent }
];

export const routing = RouterModule.forChild(routes);
export const routing: ModuleWithProviders = RouterModule.forChild(routes);
3 changes: 2 additions & 1 deletion public/docs/_examples/ngmodule/ts/app/hero/hero.routing.3.ts
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
import { ModuleWithProviders } from '@angular/core';
import { Routes,
RouterModule } from '@angular/router';

Expand All @@ -15,4 +16,4 @@ const routes: Routes = [
}
];

export const routing = RouterModule.forChild(routes);
export const routing: ModuleWithProviders = RouterModule.forChild(routes);
3 changes: 2 additions & 1 deletion public/docs/_examples/ngmodule/ts/app/hero/hero.routing.ts
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
import { ModuleWithProviders } from '@angular/core';
import { Routes,
RouterModule } from '@angular/router';

Expand All @@ -15,4 +16,4 @@ const routes: Routes = [
}
];

export const routing = RouterModule.forChild(routes);
export const routing: ModuleWithProviders = RouterModule.forChild(routes);
3 changes: 2 additions & 1 deletion public/docs/_examples/router/ts/app/app.routing.1.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
// #docplaster
// #docregion
import { ModuleWithProviders } from '@angular/core';
// #docregion route-config
import { Routes, RouterModule } from '@angular/router';

Expand Down Expand Up @@ -36,6 +37,6 @@ export const appRoutingProviders: any[] = [

];

export const routing = RouterModule.forRoot(appRoutes);
export const routing: ModuleWithProviders = RouterModule.forRoot(appRoutes);
// #enddocregion route-config
// #enddocregion
3 changes: 2 additions & 1 deletion public/docs/_examples/router/ts/app/app.routing.2.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
// #docplaster
// #docregion
import { ModuleWithProviders } from '@angular/core';
// #docregion route-config
import { Routes, RouterModule } from '@angular/router';

Expand All @@ -17,5 +18,5 @@ export const appRoutingProviders: any[] = [

];

export const routing = RouterModule.forRoot(appRoutes);
export const routing: ModuleWithProviders = RouterModule.forRoot(appRoutes);
// #enddocregion route-config
3 changes: 2 additions & 1 deletion public/docs/_examples/router/ts/app/app.routing.3.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
// #docplaster
// #docregion
import { ModuleWithProviders } from '@angular/core';
import { Routes, RouterModule } from '@angular/router';

import { CrisisListComponent } from './crisis-center/crisis-list.component';
Expand All @@ -12,4 +13,4 @@ export const appRoutingProviders: any[] = [

];

export const routing = RouterModule.forRoot(appRoutes);
export const routing: ModuleWithProviders = RouterModule.forRoot(appRoutes);
3 changes: 2 additions & 1 deletion public/docs/_examples/router/ts/app/app.routing.4.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
// #docregion
import { ModuleWithProviders } from '@angular/core';
import { Routes, RouterModule } from '@angular/router';

const appRoutes: Routes = [
Expand All @@ -9,4 +10,4 @@ export const appRoutingProviders: any[] = [

];

export const routing = RouterModule.forRoot(appRoutes);
export const routing: ModuleWithProviders = RouterModule.forRoot(appRoutes);
3 changes: 2 additions & 1 deletion public/docs/_examples/router/ts/app/app.routing.5.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
// #docregion
import { ModuleWithProviders } from '@angular/core';
import { Routes, RouterModule } from '@angular/router';

import { loginRoutes,
Expand All @@ -12,4 +13,4 @@ export const appRoutingProviders: any[] = [
authProviders
];

export const routing = RouterModule.forRoot(appRoutes);
export const routing: ModuleWithProviders = RouterModule.forRoot(appRoutes);
3 changes: 2 additions & 1 deletion public/docs/_examples/router/ts/app/app.routing.6.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
// #docregion
import { ModuleWithProviders } from '@angular/core';
// #docregion import-router
import { Routes, RouterModule } from '@angular/router';
// #enddocregion import-router
Expand Down Expand Up @@ -32,7 +33,7 @@ export const appRoutingProviders: any[] = [
CanDeactivateGuard
];

export const routing = RouterModule.forRoot(appRoutes);
export const routing: ModuleWithProviders = RouterModule.forRoot(appRoutes);
// #enddocregion

/* A link parameters array
Expand Down
3 changes: 2 additions & 1 deletion public/docs/_examples/router/ts/app/app.routing.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
// #docregion
import { ModuleWithProviders } from '@angular/core';
// #docregion import-router
import { Routes, RouterModule } from '@angular/router';
// #enddocregion import-router
Expand Down Expand Up @@ -32,4 +33,4 @@ export const appRoutingProviders: any[] = [
CanDeactivateGuard
];

export const routing = RouterModule.forRoot(appRoutes);
export const routing: ModuleWithProviders = RouterModule.forRoot(appRoutes);
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
// #docregion
import { ModuleWithProviders } from '@angular/core';
import { Routes, RouterModule } from '@angular/router';

import { CrisisDetailComponent } from './crisis-detail.component';
Expand All @@ -17,5 +18,5 @@ const crisisCenterRoutes: Routes = [
}
];

export const crisisCenterRouting = RouterModule.forChild(crisisCenterRoutes);
export const crisisCenterRouting: ModuleWithProviders = RouterModule.forChild(crisisCenterRoutes);
// #enddocregion routes
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
// #docregion
import { ModuleWithProviders } from '@angular/core';
import { Routes, RouterModule } from '@angular/router';

import { CrisisDetailComponent } from './crisis-detail.component';
Expand All @@ -24,5 +25,5 @@ const crisisCenterRoutes: Routes = [
}
];

export const crisisCenterRouting = RouterModule.forChild(crisisCenterRoutes);
export const crisisCenterRouting: ModuleWithProviders = RouterModule.forChild(crisisCenterRoutes);
// #enddocregion routes
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
// #docplaster
// #docregion
import { ModuleWithProviders } from '@angular/core';
import { Routes, RouterModule } from '@angular/router';

import { CrisisDetailComponent } from './crisis-detail.component';
Expand Down Expand Up @@ -38,7 +39,7 @@ const crisisCenterRoutes: Routes = [
}
];

export const crisisCenterRouting = RouterModule.forChild(crisisCenterRoutes);
export const crisisCenterRouting: ModuleWithProviders = RouterModule.forChild(crisisCenterRoutes);
// #enddocregion

/*
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
// #docplaster
// #docregion
import { ModuleWithProviders } from '@angular/core';
import { Routes, RouterModule } from '@angular/router';

import { CrisisDetailComponent } from './crisis-detail.component';
Expand Down Expand Up @@ -40,7 +41,7 @@ const crisisCenterRoutes: Routes = [
}
];

export const crisisCenterRouting = RouterModule.forChild(crisisCenterRoutes);
export const crisisCenterRouting: ModuleWithProviders = RouterModule.forChild(crisisCenterRoutes);
// #enddocregion

/*
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
// #docplaster
// #docregion
import { ModuleWithProviders } from '@angular/core';
import { Routes, RouterModule } from '@angular/router';

import { CrisisCenterComponent } from './crisis-center.component';
Expand Down Expand Up @@ -49,4 +50,4 @@ const crisisCenterRoutes: Routes = [
}
];

export const crisisCenterRouting = RouterModule.forChild(crisisCenterRoutes);
export const crisisCenterRouting: ModuleWithProviders = RouterModule.forChild(crisisCenterRoutes);
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
// #docplaster
// #docregion
import { ModuleWithProviders } from '@angular/core';
import { Routes, RouterModule } from '@angular/router';

import { CrisisCenterComponent } from './crisis-center.component';
Expand Down Expand Up @@ -45,6 +46,6 @@ const crisisCenterRoutes: Routes = [
}
];

export const crisisCenterRouting = RouterModule.forChild(crisisCenterRoutes);
export const crisisCenterRouting: ModuleWithProviders = RouterModule.forChild(crisisCenterRoutes);
// #enddocregion lazy-load-crisis-center
// #enddocregion
3 changes: 2 additions & 1 deletion public/docs/_examples/router/ts/app/heroes/heroes.routing.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
// #docregion
import { ModuleWithProviders } from '@angular/core';
import { Routes, RouterModule } from '@angular/router';

import { HeroListComponent } from './hero-list.component';
Expand All @@ -11,5 +12,5 @@ const heroesRoutes: Routes = [
// #enddocregion hero-detail-route
];

export const heroesRouting = RouterModule.forChild(heroesRoutes);
export const heroesRouting: ModuleWithProviders = RouterModule.forChild(heroesRoutes);
// #enddocregion
5 changes: 2 additions & 3 deletions public/docs/_examples/style-guide/ts/app/app.routes.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { RouterConfig } from '@angular/router';
import { Routes } from '@angular/router';

import { AppComponent as S0101 } from '../01-01/app';
// import { AppComponent as S0207 } from '../02-07/app';
Expand Down Expand Up @@ -27,7 +27,7 @@ import { AppComponent as S0101 } from '../01-01/app';
// import { AppComponent as S0704 } from '../07-04/app';
// import { AppComponent as S0901 } from '../09-01/app';

export const routes: RouterConfig = [
export const routes: Routes = [
{ path: '', redirectTo: '/01-01', pathMatch: 'full' },
{ path: '01-01', component: S0101 },
// { path: '02-07', component: S0207 },
Expand Down Expand Up @@ -56,4 +56,3 @@ export const routes: RouterConfig = [
// { path: '07-04', component: S0704 },
// { path: '09-01', component: S0901 },
];

Loading