chore(toh-5): improve e2e test coverage and readability (use async/await) #2092
Conversation
Improved test coverage. Also updated tests to make use of async/await (so tests are more readable).
|
@wardbell @Foxandxss @filipesilva : ready for review. cc @kwalrath |
| expect(hero.name).toEqual(targetHero.name); | ||
| }); | ||
|
|
||
| it(`updates hero name (${newHeroName}) in details view`, updateHeroNameInDetailView); |
There was a problem hiding this comment.
Isn't this the same test as line 98?
There was a problem hiding this comment.
Yes, we test the updating of the hero name twice: once when accessed via the Dashboard, and once when accessed via the Heroes list. This is how it was in the previous e2e tests.
There was a problem hiding this comment.
But I can't see how they can do anything different. Tests runs from a clean state and they seem to be run from the exact same page.
Shouldn't it be dropped? Or there is something I cannot see?
There was a problem hiding this comment.
The test groups for the Dashboard and the Heroes list are independent. I think that it is reasonable to include this single test (editing the hero name), in both test groups.
|
Leaving the comment aside, I don't dislike it, the new Hero class makes it read better. |
Improved test coverage. Also updated tests to make use of async/await (so tests are more readable).
This is part of work to get a full suite of e2e tutorial tests to run for Dart (#1619).