This repository was archived by the owner on Dec 4, 2017. It is now read-only.
chore(build): fix so --fast can be used with check-deploy etc #2083
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Works for me! |
|
I need to double check, because that concrete task had a problem with ordering and I think I had to remove the |
|
Removing the return beaks the task flow. I think that the return needs to be there in some form, we just need to find the right form (and this might be it). |
|
Doesn't seem to be affecting the ordering, so LGTM. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using
--fastwith most targets would just stop after doing_copy-example-boilerplate. This fixes the issue.cc @kwalrath @Foxandxss