This repository was archived by the owner on Dec 4, 2017. It is now read-only.
docs(template-syntax/dart): enhancements to example code #2051
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @kwalrath @thso @matanlurey : ready for review and merge. |
chalin
force-pushed
the
chalin-dart-template-syntax-ngstyle-0807
branch
from
0153bfb to
c75204c
Compare
|
LGTM, but an engineer should review the changes, if possible. |
chalin
force-pushed
the
chalin-dart-template-syntax-ngstyle-0807
branch
from
c75204c to
080e88f
Compare
Enhancements to `NgStyle` section in support of its API docs. - Add feature supporting interactive update of a paragraph’s style. - Add full type declarations. - Replace bogus implementation of `getStyles()`.
chalin
force-pushed
the
chalin-dart-template-syntax-ngstyle-0807
branch
from
080e88f to
362de13
Compare
|
We didn't get the engineer review, but the changes work and LGTM, so I'm merging. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enhancements to
NgStylesection in support of its API docs.getStyles().