This repository was archived by the owner on Dec 4, 2017. It is now read-only.
chore(install): fix install scripts & improve local usage #2041
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@wardbell @Foxandxss : ready for review and merge. |
chalin
force-pushed
the
chalin-fix-scripts-0802
branch
2 times, most recently
from
6955187 to
e0330d6
Compare
Fix a few minor problems with Travis install & build scripts. Other changes allow `before-install.sh` to be run locally.
chalin
force-pushed
the
chalin-fix-scripts-0802
branch
from
e0330d6 to
4580977
Compare
|
@filipesilva could you review this? |
|
LGTM, @chalin thanks for making the scripts more compatible with local envs! |
|
Thanks, Filipe! Merging now... |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a few minor problems with Travis install & build scripts.
Other changes allow
before-install.shto be run locally.