Skip to content
This repository was archived by the owner on Dec 4, 2017. It is now read-only.

Double slash for bundles path #1961

Closed
wants to merge 1 commit into from
Closed

Double slash for bundles path #1961

wants to merge 1 commit into from

Conversation

ziglee
Copy link
Contributor

@ziglee ziglee commented Jul 25, 2016

This slash before the bundles path is generating a double slash for the scripts path, e.g. http://localhost:3000/node_modules/@angular/common//bundles/common.umd.js. Some server are not happy with this double slash and redirect to 404 pages like Firebase Hosting.

…he scripts path, e.g. http://localhost:3000/node_modules/@angular/common//bundles/common.umd.js. Some server are not happy with this double slash and redirect to 404 pages like Firebase Hosting.
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

1 similar comment
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@ziglee
Copy link
Contributor Author

ziglee commented Jul 25, 2016

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

1 similar comment
@googlebot
Copy link

CLAs look good, thanks!

@Foxandxss
Copy link
Member

Weird, I think I tried that way in the past and it didn't work. But it certainly does.

Can you change the systemjs.config.plunker.js as well?

@ziglee
Copy link
Contributor Author

ziglee commented Jul 25, 2016

I suppose it can be changed too. I'm having some errors trying to run "npm start" inside public/docs/_examples folder to test this.

@Foxandxss
Copy link
Member

You can't do that there.

Just run gulp build-plunkers and then go to any example, inside their ts folder, there is a plunker.no-link.html. Open that file in your browser and you will go to plunker.

@ziglee
Copy link
Contributor Author

ziglee commented Jul 25, 2016

I had a problem with that too.
`gulpfile.js:515
spawnInfo = spawnExt('npm', ['install', ...sources], {cwd: EXAMPLES_PATH});
^^^

SyntaxError: Unexpected token ...`

@Foxandxss
Copy link
Member

You need node 5.

@ziglee
Copy link
Contributor Author

ziglee commented Jul 25, 2016

Plunkr works according, regardless of how the bundles path is setted at systemjs.config.plunker.js

@Foxandxss
Copy link
Member

That is weird. I will check.

@wardbell
Copy link
Contributor

Sounds good. Merging

@wardbell wardbell closed this in fccb32d Aug 18, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants